Cache language

Hi @ekes ... thanks for reporting this, but could you much more clear with all those steps to reproduce?
I read 3 or 4 times the following sentences and indeed I don't get what you mean ... especially the following:

With a geocoder with results for different languages search and the interface language set to "Santa Maria del Fiore" (Florence)

the interface language set to "Santa Maria del Fiore" (Florence)? what is that??

and also ...

and search the result will still return Florence, rather than Fiore

What is Fiore? Do you rather mean Firenze??

Please can you better reformulate your use case ... ?
and I would rather mark this as Feature Request, rather than Bug (I still don't see any evident bug, yet)

I can see if I can create other issues with the caching. But in Geo entity → what we're doing is autocompleting the address, and geocoding a point at the same time, interactively in the UI. If you install it, enable the example module, and add languages to the site you can recreate this:

If you are in the site in English do a search for something in Florence it will cache this result - with the address. You then do the same search in Italian and it will return the English result - still with the address 'Florence' not (yes) 'Firenze'. And vice versa. Clear the cache. Do it in Italian first that Italian version of the address is cached.

Ok thanks @ekes I got your point, and it makes sense to me, after testing your suggested use case.
Please review the MR and its changes: basically I added the $locale parameter in the generation of the geocoder cache ids,
with the $locale generated the same way as it is injected in the StatefulGeocoder here: https://git.drupalcode.org/project/geocoder/-/blob/8.x-4.x/src/ProviderU...

Let's make this simple and please let me know if you see clear drawbacks in this solution to this issue.

itamair → closed merge request !39

itamair → reopened merge request !39

Sorry ... I went ahead and merged this MR, as I want to add this into a incoming new release, along this fixed one: https://www.drupal.org/project/geocoder/issues/3355990 📌 Http\Client\HttpClient is deprecated: use Psr\Http\Client\ClientInterface instead Fixed
facing the imminent deploy of Drupal 10.2 ...
Feel free to re-open this if you find some major remark on this solution.

That makes sense. Thanks.

Automatically closed - issue fixed for 2 weeks with no activity.