- Issue created by @alorenc
- last update
12 months ago 28 pass - last update
12 months ago 28 pass - last update
12 months ago 28 pass - 🇵🇱Poland alorenc Wolsztyn, 🇵🇱
Updated logic for back button
Improved coding standards discovered on https://www.drupal.org/pift-ci-job/2817055 → - last update
12 months ago 28 pass - last update
12 months ago 28 pass - 🇵🇱Poland alorenc Wolsztyn, 🇵🇱
Improved coding standards of PollViewForm.php without any drustic changes. Created a follow up https://www.drupal.org/project/poll/issues/3405533 📌 Impove code standards Active for improving other files.
- last update
12 months ago 28 pass - Issue was unassigned.
- Status changed to Needs review
12 months ago 2:15pm 1 December 2023 - Status changed to RTBC
12 months ago 11:11am 5 December 2023 - 🇭🇺Hungary huzooka Hungary 🇭🇺🇪🇺
Checked the PR and it seems to be fine.
I'm not a big fun of unrelated CS violation fixes (as they usually cause merge conflicts), but I would leave this up to the decision of the maintainer. Maybe a test assertion could also be added which verifies that the back button is present in the corresponding case.
- Status changed to Needs work
9 months ago 7:11pm 16 February 2024 - 🇧🇪Belgium BramDriesen Belgium 🇧🇪
CS were already being fixed in a multitude of issues. So, it's best to rebase this of off the 2.0.x branch.
I think there is also some overlap with 📌 Anonymous users - Multiple voting from one IP Needs review . That issue is also adding/changing the
::showResultsconditions. - Status changed to Closed: duplicate
8 months ago 6:50am 10 March 2024 - 🇧🇪Belgium BramDriesen Belgium 🇧🇪
This was fixed in 🐛 Back to poll button only appears when allow anonymous vote is enabled Fixed will add credits there.
