- Issue created by @neclimdul
- Merge request !5631Issue #3405353: Convert use of TestCase::getName to forward compatible TestCase::name → (Open) created by neclimdul
- Status changed to Needs review
about 1 year ago 9:28pm 30 November 2023 - Status changed to Needs work
about 1 year ago 11:00pm 30 November 2023 - 🇮🇹Italy mondrake 🇮🇹
Done. Please comment on the issue as well as on the MR otherwise there's no way to know comments were added.
- Status changed to Needs review
11 months ago 5:41pm 29 January 2024 - Status changed to Needs work
11 months ago 8:32pm 2 February 2024 - 🇺🇸United States smustgrave
Applied the MR and did a search in the tests folder for $this->getName and there are some instances in TestRequirementsTrait::checkRequirements that could be replaced but that function is deprecated so don't see it as a problem.
The other two though could use that trait and new method I think.
- Status changed to Needs review
11 months ago 6:33pm 3 February 2024 - 🇮🇹Italy mondrake 🇮🇹
Thanks!
1.
TestSiteTearDownCommandextendsSymfony\Component\Console\Command\Command, so getName() in this context is the name of the Command, not of the TestCase.
2.TestRequirementsTrait, I'd let it rest in peace.
3. FixedScaffoldUpgradeTest - Status changed to RTBC
11 months ago 7:37pm 6 February 2024 - Assigned to mondrake
- Status changed to Needs work
10 months ago 7:08pm 13 February 2024 - Issue was unassigned.
- Status changed to Needs review
10 months ago 7:29pm 13 February 2024 - Status changed to RTBC
10 months ago 1:09am 14 February 2024 - 🇺🇸United States smustgrave
#9 I only searched tests folder
Searched modules folder and $this->getName( appeared in 3 test files (not including test modules)
Additional changes LGTM
- Status changed to Fixed
10 months ago 11:06am 14 February 2024 Automatically closed - issue fixed for 2 weeks with no activity.