- Issue created by @eiriksm
- Merge request !1Issue #3305966 by eiriksm: Media block is allowed even if not indicated as allowed → (Merged) created by eiriksm
- Status changed to Needs review
about 1 year ago 9:05am 30 November 2023 - 🇳🇴Norway eiriksm Norway
I had to change the test to allow a couple new required core blocks.
I also fixed a couple JS syntax errors that were crashing the editor
- First commit to issue fork.
- 🇳🇴Norway eiriksm Norway
Hm, I was not getting notifications from drupal gitlab, so I guess I will answer here as that increases the chance of you seeing it as well:
@eiriksm I'm failing to see why it's failing the FunctionalJavascript tests. Not sure if any screenshots are captured in the pipeline.
It's failing because of a recently introduced regression: https://git.drupalcode.org/project/gutenberg/-/commit/8f0e4f49bd87fe3bac...
Fixed with this: https://git.drupalcode.org/project/gutenberg/-/merge_requests/72/diffs?c...
Great thing to have tests I guess :p
-
marcofernandes →
committed bf4a0944 on 3.0.x authored by
eiriksm →
Resolve #3405131 "Sync 3.x with"
-
marcofernandes →
committed bf4a0944 on 3.0.x authored by
eiriksm →
- Status changed to Fixed
12 months ago 7:12pm 20 December 2023 - Status changed to Needs work
12 months ago 4:07pm 21 December 2023 - 🇵🇹Portugal marcofernandes
Hmm, something went wrong when resolving the conflicts at
gutenberg.modulefile. - 🇳🇴Norway eiriksm Norway
So that means something is not working? This means we have missing test coverage 🤓
- Merge request !85Issue #3405131: Rebase branch '3.0.x' into 3405131-sync-3.x-with → (Merged) created by marcofernandes
-
marcofernandes →
committed d5911105 on 3.0.x
Issue #3405131: Rebase branch '3.0.x' into 3405131-sync-3.x-with
-
marcofernandes →
committed d5911105 on 3.0.x
- Status changed to Fixed
12 months ago 12:05pm 22 December 2023 - 🇳🇴Norway eiriksm Norway
I'm just going to do an actual merge of 2.x instead, so the history is in both branches.
This way it's going to be trivial to merge again if needed. However, I have a feeling we will instead just cherry pick probably. Either way, this can be closed now I believe.
Automatically closed - issue fixed for 2 weeks with no activity.