Creating new schema is not updating its name after save

Created on 30 November 2023, 7 months ago
Updated 5 December 2023, 7 months ago

Problem/Motivation

Creating new schema is not reflecting its name in the scheme tab.

Steps to reproduce

Go admin/config/people/tac_lite and create a new schema by increasing the Number of Schemas. Go to the the Scheme <number> tab and give it a name and save it.

Proposed resolution

Clear the cache on submitting the schema to make the changes in effect.

🐛 Bug report
Status

RTBC

Version

1.7

Component

Code

Created by

🇮🇳India MukhtarM

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Comments & Activities

  • Issue created by @MukhtarM
  • Status changed to Needs review 7 months ago
  • 🇮🇳India MukhtarM

    Please review the patch, Thanks

  • 🇮🇳India VinmayiSwamy

    Verified and tested patch #2 in Drupal 10.1.x.



    Patch applied successfully.

    Testing steps :-
    1. Go to Drupal 10.1.x fresh installation.

    2. Install & enable Taxonomy Access Control Lite module.

    3. Apply the patch #2.

    4. Clear cache.

    5. Go to /admin/config/people/tac_lite and create a new schema by increasing the Number of Schemas.
    6. Go to the the Scheme <number> tab and give it a name and save it.

    Result :- 
    1. New scheme name reflected on save after applying the patch.
    2. Observed that flushing all the caches on submitting the scheme to make the changes in effect is also effecting to the status message. Please observe the attached before_patch and after_patch screenshots. We can see the status message on scheme save in before_patch screenshot but not in after_patch screenshot. 


    Adding screenshots for reference.

  • Status changed to Needs work 7 months ago
  • 🇮🇳India VinmayiSwamy

    Moving to Needs work.

  • Status changed to Needs review 7 months ago
  • 🇮🇳India MukhtarM

    Thank you @VinmayiSwamy for noticing it. Here is the corrected patch.

  • 🇮🇳India VinmayiSwamy

    Verified and tested patch #5 in Drupal 10.1.x.



    Patch applied successfully.

    Test Result :-
    1. New scheme name reflected on save after applying the patch.
    2. Status message also displayed after configuration save. 


    Adding screenshot and interdiff for reference.

  • Status changed to RTBC 7 months ago
  • 🇮🇳India VinmayiSwamy

    Moving to RTBC.

Production build 0.69.0 2024