Fix various bugs in the new layout_slideshow layout paragraph type

The new submodule appears under "other" on the module page, all others are under "Paragraphs", can we fix this?

Fixed in MR

drowl_paragraphs_type_layout_slideshow_theme_suggestions_paragraph_alter doesn't check for the paragraph bundle, to the suggestion applies to all paragraph bundles. Furthermore, the suggestion doesn't seem to be required at all?!

Are you going to tackle this? If I shell fix it, I please need more details what's expected, actual, etc. and if possible tracked down as far as possible to where the reasons can be found

We should not initialize slick in preview as this causes multiple issues and there is no benefit doing this

Are you solving this?
Hopefully it should be as simple as checking the view mode, where the slick init happens and exclude preview? Or even better, initialize slick based on something that's not present in the preview (like a certain field display or sth. like that which makes sense)

yes and yes

🥳🎉🪅👯‍♂️👯‍♀️

@anybody In the drowl_paragraphs_type_layout_slideshow_preprocess_layout() we need to differ between frontend and edit. Sadly the "in_preview" flag is false here.

We have this snippet in drowl_layouts (also in preprocess_layout), which correctly returns TRUE at this point, maybe we should copy this over?

  // Layout Paragraphs module support:
  if (\Drupal::service('module_handler')->moduleExists('layout_paragraphs')) {
    // Ensure each layout_paragraphs builder region is rendered, even if empty:
    // @see https://www.drupal.org/project/drowl_layouts/issues/3294075
    if (!empty($variables['layout'])) {
      $defaultRegion = $variables['layout']->getDefaultRegion();
      $hasDefaultRegion = !empty($defaultRegion);
      $isLayoutParagraphsBuilder = $hasDefaultRegion && !empty($variables['content'][$defaultRegion]['#attached']['drupalSettings']['lpBuilder']);
      if ($isLayoutParagraphsBuilder) {
        // This is a layout paragraphs builder (edit mode).
        // Set a layout twig variable to implicate we need to force rendering
        // empty regions:
        $variables['drowl_layouts_force_render'] = TRUE;
      }
    }
  }

@anybody Proposed solution: https://git.drupalcode.org/issue/drowl_paragraphs-3404946/-/commit/104c7...

Something failed. Needs rebase: https://git.drupalcode.org/project/drowl_paragraphs/-/merge_requests/76

@thomas.frobieter fixed, ready for your review ;)

Automatically closed - issue fixed for 2 weeks with no activity.