Simplenews node issue not rendered in Subcribers preffered language

Thanks for the report, well spotted. Your fix is correct, however I have suggestion that I feel is a little simpler.

This module automatically switches the language in Mailer::doSend(), which is intended to mean that email builders don't have to worry much about language. The switch happens between build() and preRender().

Unfortunately, SimplenewsNewsletterEmailBuilder calls setBodyEntity() in build(), which is before the language switch. I think if this line is moved to preRender() (create a new function) then it would then work automatically. Please could you give it a try?

Got it AdamPS. Sounds much better and I check your proposed solution soon.

Nice and clean

Great. Please can you add a comment to explain, something like this "Set the body entity in the pre-render phase to get the right language".

This module has now moved to gitlab testing which works on merge requests instead of patches (which are now deprecated for all Drupal.org). Please can you make a MR?

The translation concept is worth being explained in the Interface above preRender declaration I would say!

MR no prob 👍

Great thanks

Automatically closed - issue fixed for 2 weeks with no activity.

Unfortunately this doesn't work, sorry for the bad advice. The email policy is ignored, we only see the node entity.

The call to $email->setBodyEntity() in preRender() it comes after BodyEmailAdjuster->build() and overwrites it.

I believe we can't fix it yet. However it will be automatically fixed by 📌 Change to the phases Active in v2.x.

This was fixed by 📌 Change to the phases Active

Automatically closed - issue fixed for 2 weeks with no activity.