- ๐ฎ๐ณIndia ravi kant Jaipur
ravi kant โ made their first commit to this issueโs fork.
- ๐ฎ๐ณIndia ravi kant Jaipur
@Lucky723
The "role" attribute can be adding to your custom theme.
Also, I have created PR for the base theme. - Status changed to Needs review
about 1 year ago 8:32pm 11 March 2024 - Status changed to Postponed: needs info
about 1 year ago 1:28am 25 April 2024 - ๐ฆ๐บAustralia VladimirAus Brisbane, Australia
Just thought I'd start a discussion.
Looking at the core, both Claro and Olivero use<header role="banner">
and<footer role="contentinfo">
.
Shouldn't we use the same? - Status changed to Needs review
about 1 year ago 5:52am 25 April 2024 - ๐ฎ๐ณIndia ravi kant Jaipur
@VladimirAus
Thank you for correcting me.
You are right that we can use Reserved key work according https://developer.mozilla.org/en-US/docs/Web/Accessibility/ARIA/Roles#3._landmark_rolesI have updated MR.
Hi,
Thanks a lot for taking it.
Does it mean it will be included in the next update ? If so, do you about when the next version should be available ? (I don't know how to add it in my custom theme).- ๐ฆ๐บAustralia VladimirAus Brisbane, Australia
@ravi kant - thank you!
@Lucky723 - yep part of next release.Cheers everyone. ๐ป
- Status changed to RTBC
about 1 year ago 7:16am 25 April 2024 -
VladimirAus โ
committed 1eab5a7d on 3.0.x authored by
ravi kant โ
Issue #3404677 by ravi kant, Lucky723, VladimirAus: Accessibility :...
-
VladimirAus โ
committed 1eab5a7d on 3.0.x authored by
ravi kant โ
- Status changed to Fixed
12 months ago 1:35pm 23 May 2024 - ๐ฆ๐บAustralia VladimirAus Brisbane, Australia
Committed! Thank you! ๐ป
-
VladimirAus โ
committed 1eab5a7d on 4.0.x authored by
ravi kant โ
Issue #3404677 by ravi kant, Lucky723, VladimirAus: Accessibility :...
-
VladimirAus โ
committed 1eab5a7d on 4.0.x authored by
ravi kant โ
Automatically closed - issue fixed for 2 weeks with no activity.