- Issue created by @AstonVictor
- 🇮🇳India chetan 11
chetan 11 → made their first commit to this issue’s fork.
- Status changed to Needs review
about 1 year ago 8:08am 28 November 2023 - 🇮🇳India chetan 11
Hi,
I have added the composer.json file on above module, please check the raised MR.
Thanks. - Issue was unassigned.
- 🇺🇦Ukraine AstonVictor
Hi @chetan 11,
your composer file is not correct.
-"type": "module",
should be"type": "drupal-module",
- module should require redirect → module
-This page gives the essential Git commands for working with this project’s source files.
- is not correct description for the module
- etcI updated the composer file and fixed some code standard issues.
- Status changed to RTBC
about 1 year ago 12:34pm 28 November 2023 - thakurnishant_06 India
Hi @AstonVictor,
I've tested the changes in MR1, and the patch applied cleanly. The composer.json is now in the correct format according to Drupal standards. Additionally, the adjustments made in the .module file have resolved the code style issues, ensuring adherence to Drupal coding standards.
Thank you for your efforts and the improvements made.
Moving it to RTBC. - Status changed to Fixed
about 1 year ago 9:46am 1 December 2023 - 🇺🇦Ukraine AstonVictor
Thanks for the review.
The MR is merged and will be released in the next release.
Automatically closed - issue fixed for 2 weeks with no activity.