- Issue created by @AstonVictor
- ๐ฌ๐งUnited Kingdom DrupalGideon London
Hi
By all means, please submit a patch for the block plugin, it's something that sounds useful. However, this module intended to keep it as simple as possible to display a message on a site for a complete novice site owner. Therefore by moving to a block, it would have to be done in a separate submodule so that it was an optional addon - like the submodules for the D7 version.
There's also no need for the `_admin_route` option - because it defaults to TRUE for routes starting with '/admin', which this module does already.
Thanks.
- ๐บ๐ฆUkraine AstonVictor
Hi @DrupalGideon,
thanks for your reply
I created an issue and prepared a new MR to implement the plugin - https://www.drupal.org/project/site_status_message/issues/3408719 ๐ Add block plugin Needs review
Please, review it. - ๐บ๐ฆUkraine AstonVictor
I also found that the module uses
'access content'
permission to check access.
I guess we can add another permission to check the access. - ๐บ๐ฆUkraine AstonVictor
I've already worked on:
https://www.drupal.org/project/site_status_message/issues/3409061 ๐ Create custom permission to access the message Needs review
https://www.drupal.org/project/site_status_message/issues/3409070 โจ Migrate site_status_message_scheduler module Needs review
https://www.drupal.org/project/site_status_message/issues/3409060 ๐ Refactor configuration saving Needs review
https://www.drupal.org/project/site_status_message/issues/3418875 ๐ Setup GitLab CI pipelines for phpcs, phpstan, eslint, composer validations Needs review
https://www.drupal.org/project/site_status_message/issues/3408719 ๐ Add block plugin Needs reviewPlease, review them.
thanks - ๐ณ๐ดNorway gisle Norway
The module owner, DrupalGideon, did reply in comment #2, so any further processing of the offer to maintain and the merge requests provided should be done by the owner. I am moving it back to the Site Status Message issue queue, as there is nothing for site moderators to do.
I have contacted DrupalGideon. You can move it back to Drupal.org project ownership issue queue if there is no response by the owner by May 14.
- ๐ฌ๐งUnited Kingdom DrupalGideon London
Hi
I am not needing a co-maintainer for this project. I am still hoping to get the D10 module to the same state as the D7 module which includes automated tests and the sub modules.
Thereโs nothing to stop anyone applying their own patches to this module.
- Status changed to Closed: works as designed
7 months ago 8:05am 6 May 2024 - ๐บ๐ฆUkraine AstonVictor
Hi @DrupalGideon,
thanks for your reply.
Could you review my issues in that case? and merge fixes or close issues?
thanks