- Issue created by @dcam
- πΊπΈUnited States dcam
It's also worth noting that the PHP docs for
dirname()
explicitly say this:
Be careful when using this function in a loop that can reach the top-level directory as this can result in an infinite loop.
I feel certain that this is the cause of the GitLab failure.
- π¦πΊAustralia larowlan π¦πΊπ.au GMT+10
Can we use the DRUPAL_ROOT constant here to achieve something similar?
- Status changed to Needs review
about 1 year ago 9:25pm 26 November 2023 - last update
about 1 year ago 172 pass - πΊπΈUnited States dcam
Can we use the DRUPAL_ROOT constant here to achieve something similar?
I think so. It passes for me locally when I use it. Let's see what happens here.
- πΊπΈUnited States dcam
For the record, this change fixed the infinite loop that made GitLab CI time out. Unfortunately, the updated tests failed.
https://git.drupalcode.org/issue/aggregator-3403910/-/jobs/397253 - πΊπΈUnited States dcam
I realize now that the
setUp()
function was updated for the contrib version of Aggregator. I made some bad assumptions about it because of the$core_dir
variable. I assumed it had been like that since the time when Aggregator was actually nested inside of Drupal'score
directory. But I see that the code is actually looking for Drupal's docroot.This doesn't really change anything. I'm still not sure why the updated test is failing on GitLab CI. I only wanted to correct my earlier mistake.
- last update
about 1 year ago 172 pass - πΊπΈUnited States dcam
This patch passed on GitLab CI. If it passes here, then it'll be ready.
- Status changed to Fixed
about 1 year ago 5:03am 29 November 2023 Automatically closed - issue fixed for 2 weeks with no activity.