- Issue created by @dcam
- last update
about 1 year ago 172 pass - last update
about 1 year ago CI aborted - last update
about 1 year ago 172 pass - 🇺🇸United States dcam
It looks like it's hanging here:
Test 'Drupal\Tests\aggregator\Unit\Menu\AggregatorLocalTasksTest::testAggregatorAdminLocalTasks with data set #0 ('aggregator.admin_overview')' started
I never would have called it hanging on a Unit test.
- last update
about 1 year ago 172 pass - last update
about 1 year ago 172 pass - last update
about 1 year ago 172 pass - last update
about 1 year ago 172 pass - last update
about 1 year ago 172 pass - Status changed to Needs review
about 1 year ago 5:46am 29 November 2023 - 🇺🇸United States dcam
@larowlan you're more familiar with GitLab CI configuration than I am. Can you think of any changes you would make to the configuration defaults?
- 🇺🇸United States dcam
Also, sorry the history of this issue is such a mess. It took me a while to figure out how to fix that test. Also, I'm still getting used to how issue forks work.
- 🇦🇺Australia larowlan 🇦🇺🏝.au GMT+10
For contrib the default is normally enough unless you want to disallow fails for phpcs and phpstan
But we can do that in separate issues that fix the bugs too
https://git.drupalcode.org/project/aggregator/-/pipelines/56502
There's a phpstan baseline we can commit here https://git.drupalcode.org/project/aggregator/-/jobs/408062/artifacts/br... and then make it force failure. Any new regressions will cause a fail.
- 🇺🇸United States dcam
I'm ok with doing that later after the existing failures are fixed.
- Status changed to Fixed
about 1 year ago 3:09pm 29 November 2023 Automatically closed - issue fixed for 2 weeks with no activity.