- Issue created by @mingsong
- π¦πΊAustralia larowlan π¦πΊπ.au GMT+10
I'd be +1 for preventing this functionality for private files
- π¦πΊAustralia mingsong π¦πΊ
The test to expose this issue, which will fail without having this issue fixed.
- π¦πΊAustralia mingsong π¦πΊ
The patch to fix this issue including new test.
The changes made by this patch are:
- Creating a new media entity for a private file will be forbidden. (403)
- Remove the link to create a new media entity for a private file in the files overview.
- New test to cover the use case of private file.
- last update
about 1 year ago 2 pass - Status changed to Needs review
about 1 year ago 11:37pm 2 December 2023 - last update
about 1 year ago 2 pass - π¦πΊAustralia mingsong π¦πΊ
The MR also fixed some code standard issues.
- Status changed to Needs work
about 1 year ago 10:16pm 3 January 2024 - π¦πΊAustralia larowlan π¦πΊπ.au GMT+10
Left some comments on the MR
- last update
about 1 year ago 2 pass - π¦πΊAustralia mingsong π¦πΊ
Thanks @larowlan, I changed the approach to check if a file is downloadable for public.
The changes from previous are,
https://git.drupalcode.org/project/file_to_media/-/merge_requests/1/diff...
- last update
about 1 year ago 2 pass -
larowlan β
committed 9e8394ad on 1.x authored by
Mingsong β
Issue #3403904 by Mingsong: Private file can not be published
-
larowlan β
committed 9e8394ad on 1.x authored by
Mingsong β
- Status changed to Needs review
about 1 year ago 12:36am 4 January 2024 - Status changed to Fixed
about 1 year ago 12:37am 4 January 2024 - π¦πΊAustralia larowlan π¦πΊπ.au GMT+10
Thanks will tag a new release
- π¦πΊAustralia larowlan π¦πΊπ.au GMT+10
https://www.drupal.org/project/file_to_media/releases/1.0.2 β thanks for your work here π
Automatically closed - issue fixed for 2 weeks with no activity.