#admin_notes do not appear without Tippy

Created on 23 November 2023, 7 months ago
Updated 19 April 2024, 2 months ago

If Tippy is not installed, generally element descriptions are used instead. However, the value of #admin_notes still appears as the Tippy question mark, but it does not work; no tooltip is displayed.

πŸ› Bug report
Status

Fixed

Version

6.2

Component

Code

Created by

πŸ‡¨πŸ‡¦Canada Liam Morland Ontario, CA πŸ‡¨πŸ‡¦

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Merge Requests

Comments & Activities

  • Issue created by @Liam Morland
  • Status changed to Needs work 7 months ago
  • πŸ‡ΊπŸ‡ΈUnited States jrockowitz Brooklyn, NY

    The attached webform can be used to show most of the areas impacted when the tippyjs library is disabled.

    Features/areas impacted.

    • Admin notes - Question mark is displayed with no tooltip
    • Webform shortcuts - Question mark is displayed with no tooltip
    • Element - Nothing is displayed

    Notes

    • Configuration/Settings elements are fine because the #description is displayed below the element.
    • Anywhere is '#type' = 'webform_help' is impacted (see attached text file)

    Thoughts

    • If this is the first time someone is noting this issue, it might not be an issue because no one is disabling tippyjs.
    • We could stop people from disabling tippyjs or display a warning when the do disable tippyjs.
    • We could block the rendering to an empty question mark via \Drupal\webform\Element\WebformHelp.
  • πŸ‡¨πŸ‡¦Canada Liam Morland Ontario, CA πŸ‡¨πŸ‡¦

    I noticed it now because I hadn't used #admin_notes before. I've always had a few JS libraries as possible enabled, just Tabby because the UI doesn't work properly without it. I think it would be best if the #admin_notes much like the descriptions do for other elements with Tippy is disabled.

  • Status changed to Needs review 7 months ago
  • πŸ‡ΊπŸ‡ΈUnited States jrockowitz Brooklyn, NY

    Let's agree to fix your immediate issue with #admin_notes and address other tippyjs issues as the come up.

  • Open in Jenkins β†’ Open on Drupal.org β†’
    Core: 10.1.x + Environment: PHP 8.2 & MySQL 8
    last update 7 months ago
    536 pass
  • Pipeline finished with Success
    7 months ago
    Total: 1790s
    #58578
  • Pipeline finished with Success
    3 months ago
    Total: 212s
    #138379
  • Pipeline finished with Success
    3 months ago
    Total: 369s
    #138386
  • Pipeline finished with Skipped
    3 months ago
    #138587
  • Pipeline finished with Skipped
    3 months ago
    #138588
  • Open in Jenkins β†’ Open on Drupal.org β†’
    Core: 10.1.4 + Environment: PHP 8.2 & MySQL 8
    9:59
    8:57
    Running
  • Pipeline finished with Skipped
    3 months ago
    #138589
  • Open in Jenkins β†’ Open on Drupal.org β†’
    Core: 10.1.4 + Environment: PHP 8.2 & MySQL 8
    9:47
    7:57
    Running
  • Status changed to Fixed 3 months ago
  • πŸ‡ΊπŸ‡ΈUnited States jrockowitz Brooklyn, NY
  • Automatically closed - issue fixed for 2 weeks with no activity.

Production build 0.69.0 2024