- Issue created by @Liam Morland
- Status changed to Needs work
7 months ago 12:54pm 2 December 2023 - πΊπΈUnited States jrockowitz Brooklyn, NY
The attached webform can be used to show most of the areas impacted when the tippyjs library is disabled.
Features/areas impacted.
- Admin notes - Question mark is displayed with no tooltip
- Webform shortcuts - Question mark is displayed with no tooltip
- Element - Nothing is displayed
Notes
- Configuration/Settings elements are fine because the #description is displayed below the element.
- Anywhere is
'#type' = 'webform_help'
is impacted (see attached text file)
Thoughts
- If this is the first time someone is noting this issue, it might not be an issue because no one is disabling tippyjs.
- We could stop people from disabling tippyjs or display a warning when the do disable tippyjs.
- We could block the rendering to an empty question mark via \Drupal\webform\Element\WebformHelp.
- π¨π¦Canada Liam Morland Ontario, CA π¨π¦
I noticed it now because I hadn't used
#admin_notes
before. I've always had a few JS libraries as possible enabled, just Tabby because the UI doesn't work properly without it. I think it would be best if the#admin_notes
much like the descriptions do for other elements with Tippy is disabled. - Status changed to Needs review
7 months ago 11:28am 3 December 2023 - πΊπΈUnited States jrockowitz Brooklyn, NY
Let's agree to fix your immediate issue with #admin_notes and address other tippyjs issues as the come up.
- Merge request !384Issue #3403835: #admin_notes do not appear without Tippy β (Merged) created by jrockowitz
- last update
7 months ago 536 pass 9:59 8:57 Running9:47 7:57 Running-
jrockowitz β
committed 34d926cb on 6.2.x
Issue #3403835: #admin_notes do not appear without Tippy
-
jrockowitz β
committed 34d926cb on 6.2.x
- Status changed to Fixed
3 months ago 10:37am 5 April 2024 Automatically closed - issue fixed for 2 weeks with no activity.