- Issue created by @chancenyasulu
- ๐ฎ๐ณIndia Vivek Panicker Kolkata
Vivek Panicker โ made their first commit to this issueโs fork.
- Merge request !13403593: Fixed issues reported by codesniffer and added support for D10. โ (Merged) created by Vivek Panicker
- Status changed to Needs review
about 1 year ago 6:47am 24 November 2023 - ๐ฎ๐ณIndia Vivek Panicker Kolkata
@chancenyasulu Please review the MR.
- ๐ฒ๐ผMalawi chancenyasulu
Hey @vivekp27 I have reviewed this mr rest are fine except in this file web/modules/contrib/views_sort_length/src/Plugin/views/sort/Length.php on method public function query()
inheritdoc is inheriting not standardized comment block which is still give errors so you can override this by following this
/**
* This is a description with capital T and period at an end.
*
* {@inheritdoc }
*/Thank you.
- ๐ฎ๐ณIndia Vivek Panicker Kolkata
@chancenyasulu I checked this.
In SortPluginBase class, we have the query method defined.
`Length` class extends SortPluginBase class and overrides its `query()`.
So adding `{@inheritDoc}` on the function docblock does not cause any error.
Even VSCode โ is not showing any error.
- ๐ฎ๐ณIndia Vivek Panicker Kolkata
@chancenyasulu I see the it written as
{@inheritDoc }<code> in your code. An extra space seems to have crept in. Can you please fix that to <code>{@inheritDoc}
and run phpcs again?
- Status changed to RTBC
about 1 year ago 12:11pm 28 November 2023 - Status changed to Fixed
about 1 year ago 5:01pm 4 December 2023 Automatically closed - issue fixed for 2 weeks with no activity.