- Issue created by @zniki.ru
- ๐ฎ๐ณIndia Keshav Patel
Keshav Patel โ made their first commit to this issueโs fork.
- Merge request !5512Issue #3403558: Simplify ListItemBase::validateAllowedValues() โ (Open) created by Keshav Patel
- Status changed to Needs review
7 months ago 4:48am 23 November 2023 - ๐ฎ๐ณIndia Keshav Patel
Changes made in the above MR (#3) to make code more readable, Please review.
- Status changed to Needs work
7 months ago 5:56am 23 November 2023 - ๐ท๐บRussia zniki.ru
Thanks for MR, please check my comments.
Looks like there is a bug with Drupal.WhiteSpace.ScopeIndent.IncorrectExact phpcs rule.
- First commit to issue fork.
- Status changed to Needs review
6 months ago 11:39am 28 December 2023 - ๐ฎ๐ณIndia Keshav Patel
Update the MR, Please Review.
array_filter function:
The array_filter function with the provided callback functionfunction ($item) { return $item; }
removes the empty strings('') and NULL values from $items array, giving out the filtered array.
- Status changed to Needs work
6 months ago 12:17pm 28 December 2023 - Status changed to Needs review
6 months ago 6:12pm 28 December 2023 - ๐ฎ๐ณIndia Keshav Patel
Nikolay Shapovalov, Re-ran the failed test job "#542553: PHP 8.2 MySQL 8" it Passed!
- Status changed to Needs work
6 months ago 8:14pm 30 December 2023 - ๐บ๐ธUnited States smustgrave
Any new features should have test coverage, but maybe this is a task. Didn't wnat to make that call though.
Also even simple tickets should still have a filled out issue summary.
Thanks.