Remove settings service since it is an anti-pattern

Looks good to me, but the phpcs errors are yours to fix. (Basically all failures are of the actual issue now... except the single PHPUnit error which needs to be fixed in the other issue I guess.)

We should likely deprecate the service?
https://www.drupal.org/about/core/policies/core-change-policies/drupal-d... →

Since we're out of alpha, I'm guessing we shouldn't just remove it from services.yml because people could be using it. But just a message per the above link seems good.

Per above comment: We should likely deprecate the service?

Should I do that? I'm not RTBC'ing this without working this out.

let's simply get rid of the old service, we are in beta phase and I very very much doubt someone was using that.

Great. No other tests needed besides removing it (because it's not mentioned anywhere).

Build pipeline is green except the one PHPUnit error fixed by 🐛 Respect installations with base paths Needs review .

thx, merged

Automatically closed - issue fixed for 2 weeks with no activity.