issues reported by phpcs

$ vendor/bin/phpcs -s $_WEB_ROOT/modules/custom --report-junit=junit.xml --report-full --report-summary --report-source FILE: ...eb/modules/custom/ldap_sso-3402953/src/LdapSsoBootSubscriber.php ---------------------------------------------------------------------- FOUND 1 ERROR AFFECTING 1 LINE ---------------------------------------------------------------------- 9 | ERROR | [x] Use statements should be sorted alphabetically. The | | first wrong one is | | Drupal\Core\Path\CurrentPathStack. | | (SlevomatCodingStandard.Namespaces.AlphabeticallySortedUses.IncorrectlyOrderedUses) ---------------------------------------------------------------------- PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY ---------------------------------------------------------------------- FILE: ...eb/modules/custom/ldap_sso-3402953/src/Form/LdapSsoAdminForm.php ---------------------------------------------------------------------- FOUND 1 ERROR AFFECTING 1 LINE ---------------------------------------------------------------------- 10 | ERROR | [x] Use statements should be sorted alphabetically. The | | first wrong one is | | Drupal\Core\Form\ConfigFormBase. | | (SlevomatCodingStandard.Namespaces.AlphabeticallySortedUses.IncorrectlyOrderedUses) ---------------------------------------------------------------------- PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY ---------------------------------------------------------------------- FILE: ...dules/custom/ldap_sso-3402953/src/Controller/LoginController.php ---------------------------------------------------------------------- FOUND 1 ERROR AFFECTING 1 LINE ---------------------------------------------------------------------- 14 | ERROR | [x] Use statements should be sorted alphabetically. The | | first wrong one is | | Drupal\Core\Session\AccountInterface. | | (SlevomatCodingStandard.Namespaces.AlphabeticallySortedUses.IncorrectlyOrderedUses) ---------------------------------------------------------------------- PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY ---------------------------------------------------------------------- Time: 198ms; Memory: 6MB PHP CODE SNIFFER REPORT SUMMARY ---------------------------------------------------------------------- FILE ERRORS WARNINGS ---------------------------------------------------------------------- ...om/ldap_sso-3402953/src/LdapSsoBootSubscriber.php 1 0 ...ap_sso-3402953/src/Controller/LoginController.php 1 0 ...om/ldap_sso-3402953/src/Form/LdapSsoAdminForm.php 1 0 ---------------------------------------------------------------------- A TOTAL OF 3 ERRORS AND 0 WARNINGS WERE FOUND IN 11 FILES ---------------------------------------------------------------------- PHPCBF CAN FIX 3 OF THESE SNIFF VIOLATIONS AUTOMATICALLY ---------------------------------------------------------------------- PHP CODE SNIFFER VIOLATION SOURCE SUMMARY ---------------------------------------------------------------------- SOURCE COUNT ---------------------------------------------------------------------- [x] SlevomatCodingStandard.Namespaces.AlphabeticallySortedUses. 3 ---------------------------------------------------------------------- A TOTAL OF 3 SNIFF VIOLATIONS WERE FOUND IN 1 SOURCE ---------------------------------------------------------------------- PHPCBF CAN FIX THE 1 MARKED SOURCES AUTOMATICALLY (3 VIOLATIONS IN TOTAL) ----------------------------------------------------------------------

Comments & Activities

Issue created by @bluegeek9
Merge request !8Issue #3402959: issues reported by phpcs → (Merged) created by bluegeek9
Open in Jenkins → Open on Drupal.org →
Core: 10.1.4 + Environment: PHP 7.4 & MySQL 8
last update 7 months ago
Composer require failure
Issue was unassigned.
Status changed to Needs review 7 months ago10:41pm 20 November 2023
Comment 7 months ago →
🇺🇸United States bluegeek9

Comment 7 months ago →

🇵🇭Philippines clarkssquared

Hi bluegeek9

I applied your MR !8 and I confirmed that it fixes all the PHPCS issues, retaining the status to needs review so that others can give their feedback with your MR.

➜  ldap_sso git:(bc6bde5) curl https://git.drupalcode.org/project/ldap_sso/-/merge_requests/8.diff | patch -p1
  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                 Dload  Upload   Total   Spent    Left  Speed
100  2462    0  2462    0     0   4779      0 --:--:-- --:--:-- --:--:--  4973
patching file 'src/Controller/LoginController.php'
patching file 'src/Form/LdapSsoAdminForm.php'
patching file 'src/LdapSsoBootSubscriber.php'
➜  ldap_sso git:(bc6bde5) ✗ ..
➜  contrib git:(master) ✗ phpcs --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,css,info,txt,md,yml ldap_sso
➜  contrib git:(master) ✗

Open in Jenkins → Open on Drupal.org →
Core: 10.1.4 + Environment: PHP 7.4 & MySQL 8
last update 7 months ago
Composer require failure
Open in Jenkins → Open on Drupal.org →
Core: 10.1.4 + Environment: PHP 7.4 & MySQL 8
last update 7 months ago
Composer require failure
Open in Jenkins → Open on Drupal.org →
Core: 10.1.4 + Environment: PHP 7.4 & MySQL 8
last update 7 months ago
Composer require failure
Open in Jenkins → Open on Drupal.org →
Core: 10.1.4 + Environment: PHP 7.4 & MySQL 8
last update 7 months ago
Composer require failure
Comment 7 months ago →
System Message

bluegeek9 → committed 7efc7f72 on 8.x-4.x
Issue #3402959 by bluegeek9, clarkssquared: issues reported by phpcs
Status changed to Fixed 7 months ago5:52pm 17 December 2023
Comment 7 months ago →
🇺🇸United States bluegeek9
Comment 6 months ago →
System Message
Automatically closed - issue fixed for 2 weeks with no activity.

Problem/Motivation

Steps to reproduce

Proposed resolution

Remaining tasks

User interface changes

API changes

Data model changes

Merge Requests

!8issues reported by phpcs
Merged

Comments & Activities

issues reported by phpcs

Problem/Motivation

Steps to reproduce

Proposed resolution

Remaining tasks

User interface changes

API changes

Data model changes

Merge Requests

!8issues reported by phpcsMerged

Comments & Activities

!8issues reported by phpcs
Merged