Contrib.social

Upgrading from 2.0.0-rc2 to 2.1.0-beta2 results in error on Manifest form

Open on Drupal.org →
Created on 20 November 2023, about 1 year ago
Updated 7 February 2024, 11 months ago

Hi everyone.
I came across this issue today after updating to the latest beta version of the module.

Problem/Motivation

Steps to reproduce

Install or update to version 2.1.0-beta2.
Visit /admin/config/services/pwa/manifest
I get the following error:

The website encountered an unexpected error. Please try again later.

TypeError: implode(): Argument #1 ($pieces) must be of type array, string given in implode() (line 255 of modules/contrib/pwa/src/Form/ManifestConfigurationForm.php).

Drupal\pwa\Form\ManifestConfigurationForm->buildForm()
call_user_func_array() (Line: 536)
Drupal\Core\Form\FormBuilder->retrieveForm() (Line: 283)
Drupal\Core\Form\FormBuilder->buildForm() (Line: 73)
Drupal\Core\Controller\FormController->getContentResult()
call_user_func_array() (Line: 123)
Drupal\Core\EventSubscriber\EarlyRenderingControllerWrapperSubscriber->Drupal\Core\EventSubscriber\{closure}() (Line: 592)
Drupal\Core\Render\Renderer->executeInRenderContext() (Line: 121)
Drupal\Core\EventSubscriber\EarlyRenderingControllerWrapperSubscriber->wrapControllerExecutionInRenderContext() (Line: 97)
Drupal\Core\EventSubscriber\EarlyRenderingControllerWrapperSubscriber->Drupal\Core\EventSubscriber\{closure}() (Line: 181)
Symfony\Component\HttpKernel\HttpKernel->handleRaw() (Line: 76)
Symfony\Component\HttpKernel\HttpKernel->handle() (Line: 58)
Drupal\Core\StackMiddleware\Session->handle() (Line: 48)
Drupal\Core\StackMiddleware\KernelPreHandle->handle() (Line: 106)
Drupal\page_cache\StackMiddleware\PageCache->pass() (Line: 85)
Drupal\page_cache\StackMiddleware\PageCache->handle() (Line: 48)
Drupal\Core\StackMiddleware\ReverseProxyMiddleware->handle() (Line: 51)
Drupal\Core\StackMiddleware\NegotiationMiddleware->handle() (Line: 51)
Drupal\Core\StackMiddleware\StackedHttpKernel->handle() (Line: 704)
Drupal\Core\DrupalKernel->handle() (Line: 19)

Proposed resolution

Currently n/a

Remaining tasks

n/a

User interface changes

n/a

API changes

n/a

Data model changes

n/a

🐛 Bug report
Status

Closed: cannot reproduce

Version

2.1

Component

Code

Created by

🇳🇱Netherlands left

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Comments & Activities

  • Issue created by @left
  • Comment about 1 year ago →
    🇳🇱Netherlands left

    I noticed I'd neglected to run php updates after I installed the update and there are some pending for PWA. This might have been the cause.
    I will follow up.

  • Comment about 1 year ago →
    🇳🇱Netherlands left

    I'm pretty sure this was user error, so I will close this.
    Sorry for the noise :)

  • Status changed to Closed: works as designed about 1 year ago
  • Comment about 1 year ago →
    🇳🇱Netherlands left
  • Status changed to Needs review 11 months ago
  • Open in Jenkins → Open on Drupal.org →
    Core: 10.2.1 + Environment: PHP 8.1 & MySQL 8
    last update 11 months ago
    11 pass
  • Comment 11 months ago →
    🇩🇪Germany larskleiner

    We are getting the same error on a manifest form with no categories configured. I guess you didn't got that error anymore once you added categories to the manifest form. Attached patch should fix this error.

  • Status changed to Closed: cannot reproduce 11 months ago
  • Comment 11 months ago →
    🇩🇪Germany Grevil

    @larskleiner please run "drush updb" and clear your caches, like the OC of this issue.

contrib.social Blog FAQ Discussions
Production build 0.71.5 2024