- Issue created by @brad.bulger
- 🇺🇸United States brad.bulger
This patch file spells out the changes that worked for me.
- 🇺🇸United States justcaldwell Austin, Texas
I think this core issue is the possible culprit: 🐛 [10.2 regression] CKEditor 5 breaks when "Source"/Source editing button is added and "Manually editable HTML tags" are specified Needs review .
- Assigned to justcaldwell
- 🇺🇸United States justcaldwell Austin, Texas
Okay, maybe not (re #3). I applied the latest 10.2.x patch from 3410100 and the issue persists.
Since we know all the classnames we're using here, seems reasonable to be more specific than just
<p class>
as @brad.bulger suggests. Using a wildcard in the class (i.e.<p class="Indent*">
) should work and will be a bit cleaner. - last update
8 months ago 1 pass - last update
8 months ago 1 pass - 🇺🇸United States justcaldwell Austin, Texas
The changes in the MR worked in my testing. Please review.
Static patch attached.
- Issue was unassigned.
- Status changed to Needs review
8 months ago 4:56pm 15 May 2024 - First commit to issue fork.
- 🇺🇸United States trackleft2 Tucson, AZ 🇺🇸
FYI I've updated the merge request to merge in upstream changes and fix a merge conflict with those upstream changes.
#6 should still apply to version8.x-1.0
- Status changed to RTBC
6 months ago 8:00pm 5 August 2024 - 🇺🇸United States trackleft2 Tucson, AZ 🇺🇸
I've tested the patch in comment #6 on a site using Drupal Core 10.3.1 and version 8.x-1.0 of the
ckeditor_indentblock
module.My configuration for source editing is this:
<abbr> <address> <cite> <dl> <dt> <dd> <div class name id data-*> <span class name id> <img src alt data-entity-type data-entity-uuid> <footer class> <blockquote class> <ul type class> <ol type class> <li class> <h1 class name id> <h2 class name id> <h3 class name id> <h4 class name id> <h5 class name id> <h6 class name id> <table class> <tbody class> <thead class> <tfoot class> <th class scope> <td class> <tr class colspan rowspan> <hr class> <a class target name id title> <drupal-entity data-entity-type data-embed-button alt title data-align data-caption data-entity-embed-display data-entity-embed-display-settings data-view-mode data-entity-uuid data-langcode> <drupal-media title> <p class>
- First commit to issue fork.
-
heddn →
committed 24eae697 on 8.x-1.x authored by
justcaldwell →
Issue #3402570 by justcaldwell, trackleft2, heddn: Plugin blocks other...
-
heddn →
committed 24eae697 on 8.x-1.x authored by
justcaldwell →
- Status changed to Fixed
2 months ago 7:55pm 20 November 2024 Automatically closed - issue fixed for 2 weeks with no activity.