- Issue created by @dk-massive
- @dk-massive opened merge request.
- Status changed to Needs review
about 1 year ago 4:41pm 17 November 2023 - Status changed to Needs work
about 1 year ago 4:44pm 17 November 2023 The Needs Review Queue Bot → tested this issue.
While you are making the above changes, we recommend that you convert this patch to a merge request → . Merge requests are preferred over patches. Be sure to hide the old patch files as well. (Converting an issue to a merge request without other contributions to the issue will not receive credit.)
- Status changed to Postponed: needs info
about 1 year ago 10:13am 22 November 2023 - 🇧🇪Belgium wim leers Ghent 🇧🇪🇪🇺
Thanks for creating this! I was blissfully unaware of this 😳
Could you please update the summary to provide concrete steps to reproduce that justify the need for this plugin/feature?
It also seems that this won't work for nested lists?
Related:
I updated the description with steps to reproduce.
I see the lack of support for nested lists has been made into a bug of the plugin.
- Status changed to Active
about 1 year ago 10:53am 30 November 2023 - 🇧🇪Belgium wim leers Ghent 🇧🇪🇪🇺
@Drupalite1411 reported the same problem at ✨ Enable AdjacentListsSupport plugin Postponed: needs info .
This happens even when using (i.e. with GHS on in a mode that allows everything).
Thanks for the crystal clear issue summary, @dk-massive!
- Status changed to Needs work
about 1 year ago 10:55am 30 November 2023 - 🇧🇪Belgium wim leers Ghent 🇧🇪🇪🇺
The MR looks fine! 👍
The missing piece that prevents me from RTBC'ing this: test coverage. It should be pretty simple to expand
\Drupal\Tests\ckeditor5\FunctionalJavascript\CKEditor5Test::testListPlugin()
— do you think you could take that on, @dk-massive? 🤓🙏 - 🇮🇳India drupalite1411
Hi Wim , I am using Drupal core version 10.1.6 and I have #3 patch but it is giving me error Composer detected issues in your platform: Your Composer dependencies require a PHP version ">= 8.2.0".
I think this patch will in core 11 - 🇧🇪Belgium wim leers Ghent 🇧🇪🇪🇺
Using the patch is unrelated to your Composer error. 😅 That's weird. There must be some Composer problem on your local dev environment.
- 🇮🇳India drupalite1411
Hi Wim, Yeah :D
I don't know my project was working fine in 8.1 and as soon as I applied the patch it asks for 8.2. May be composer update or something.
Anyways I have applied this patch https://git.drupalcode.org/project/drupal/-/merge_requests/5454.diff and it resolved the issue.
Thanks