- Issue created by @jonathan1055
- last update
over 1 year ago 4 pass - @jonathan1055 opened merge request.
- last update
over 1 year ago 2 pass, 4 fail - π¬π§United Kingdom jonathan1055
I think the reason this fails on gitlab is that the core uninstall form does not yet have
$form['#attached']['library'][] = 'core/drupal.tableresponsive';
We added this, as a patch in drupalci.yml. So need to do the same for GitLabCI.
The original core isssue π Uninstall form does not add drupal.tableresponsive library Closed: duplicate is closed as a dupliacte becauae that fix was added to π Modules uninstall filter does not filter by machine name Needs work
- last update
over 1 year ago 2 pass, 4 fail - last update
over 1 year ago 4 pass - Status changed to Needs review
over 1 year ago 4:32pm 17 November 2023 - π¬π§United Kingdom jonathan1055
Pipeline phpunit passes green now.
Also set eslint to be a warning not failure, so that the pipeline result is amber not red.
Ready for review. -
smustgrave β
committed d8630121 on 4.x authored by
jonathan1055 β
Issue #3402384 Uninstall page test
-
smustgrave β
committed d8630121 on 4.x authored by
jonathan1055 β
- Status changed to Fixed
over 1 year ago 4:34pm 17 November 2023 - π¬π§United Kingdom jonathan1055
Thanks. Odd coincidence because I found the problem, went to that issue saw your comment asking me to update the MR for core 11.x. I will try to do that soon.
Automatically closed - issue fixed for 2 weeks with no activity.