Uninstall form does not add drupal.tableresponsive library

Created on 9 January 2023, over 1 year ago

Updated 19 February 2023, over 1 year ago

Problem/Motivation

buildForm() does not add the 'core/drupal.tableresponsive' library, whereas the corresponding install form does add this library. The missing library means that javascript tests for checking the filtering of modules on the uninstall form does not work. The page does not refresh with any changes when a filter value is entered.

Steps to reproduce

See the uploaded recording of the failing test for module_filter. I am guessing that the problem is not noticed when using the UI form interactively, as maybe some other process is covering the responsive refeshing. But in the pared-down javascript test it is missing and the test fails. The test for the install page works fine as-is, because the drupal.tableresponsive is already added in the form.

Proposed resolution

Add $form['#attached']['library'][] = 'core/drupal.tableresponsive'; to the buildForm() function.
See uploaded recording of the test which works when this library is added.

Remaining tasks

🐛 Bug report

Status

Closed: duplicate

Version

10.1 ✨

Component

Form →

Last updated about 9 hours ago

Maintained by
🇺🇸United States @effulgentsia
🇺🇸United States @tim.plunkett

Created by

🇬🇧United Kingdom jonathan1055

Live updates comments and jobs are added and updated live.

Incomplete comments

Comments & Activities

Not all content is available!

It's likely this issue predates Contrib.social: some issue and comment data are missing.

Comment over 1 year ago →
🇬🇧United Kingdom jonathan1055
This fix is now included in 🐛 Modules uninstall filter does not filter by machine name Needs work so is not be required to be committed at 10.1.x. It may be backported to 10.0 and 9.5 but that is not decided yet.

So, leaving this issue open as the patch is used in module_filter testing at D10 and D9.
Status changed to Closed: duplicate over 1 year ago11:57pm 19 February 2023
Comment over 1 year ago →
🇺🇸United States smustgrave
Since it's included over there lets keep pushing that ticket forward.

contrib.social Blog FAQ Discussions

Production build 0.69.0 2024