[1.0.x] Zalo Zns

Thank you for applying!

Please read Review process for security advisory coverage: What to expect → for more details and Security advisory coverage application checklist → to understand what reviewers look for. Tips for ensuring a smooth review → gives some hints for a smoother review.

The important notes are the following.

• If you have not done it yet, you should run phpcs --standard=Drupal,DrupalPractice on the project, which alone fixes most of what reviewers would report.
• For the time this application is open, only your commits are allowed.
• The purpose of this application is giving you a new drupal.org role that allows you to opt projects into security advisory coverage, either projects you already created, or projects you will create. The project status won't be changed by this application and no other user will be able to opt projects into security advisory policy.
• We only accept an application per user. If you change your mind about the project to use for this application, or it is necessary to use a different project for the application, please update the issue summary with the link to the correct project and the issue title with the project name and the branch to review.

To the reviewers

Please read How to review security advisory coverage applications → , Application workflow → , What to cover in an application review → , and Tools to use for reviews → .

The important notes are the following.

• It is preferable to wait for a Code Review Administrator before commenting on newly created applications. Code Review Administrators will do some preliminary checks that are necessary before any change on the project files is suggested.
• Reviewers should show the output of a CLI tool → only once per application.
• It may be best to have the applicant fix things before further review.

For new reviewers, I would also suggest to first read In which way the issue queue for coverage applications is different from other project queues → .

Please review the errors found by drupal-check

------ ----------------------------------------------------------------------
Line src/Form/ZaloZnsTestForm.php
------ ----------------------------------------------------------------------
24 Property Drupal\zalo_zns\Form\ZaloZnsTestForm::$messageNotifier has
unknown class Drupal\message_notify\MessageNotifier as its type.
💡 Learn more at https://phpstan.org/user-guide/discovering-symbols
24 Property Drupal\zalo_zns\Form\ZaloZnsTestForm::$messageNotifier has
unknown class Drupal\message_notify\MessageNotifier as its type.
💡 Learn more at https://phpstan.org/user-guide/discovering-symbols
36 Parameter $messageNotifier of method
Drupal\zalo_zns\Form\ZaloZnsTestForm::__construct() has invalid type
Drupal\message_notify\MessageNotifier.
156 Call to static method create() on an unknown class
Drupal\message\Entity\Message.
💡 Learn more at https://phpstan.org/user-guide/discovering-symbols
161 Call to method send() on an unknown class
Drupal\message_notify\MessageNotifier.
💡 Learn more at https://phpstan.org/user-guide/discovering-symbols
------ ----------------------------------------------------------------------

------ --------------------------------------------------------------------------
Line src/Plugin/Notifier/ZaloZns.php
------ --------------------------------------------------------------------------
20 Class Drupal\zalo_zns\Plugin\Notifier\ZaloZns extends unknown class
Drupal\message_notify\Plugin\Notifier\MessageNotifierBase.
💡 Learn more at https://phpstan.org/user-guide/discovering-symbols
29 Access to an undefined property
Drupal\zalo_zns\Plugin\Notifier\ZaloZns::$message.
💡 Learn more:
https://phpstan.org/blog/solving-phpstan-access-to-undefined-property
78 Access to an undefined property
Drupal\zalo_zns\Plugin\Notifier\ZaloZns::$message.
💡 Learn more:
https://phpstan.org/blog/solving-phpstan-access-to-undefined-property
79 Access to an undefined property
Drupal\zalo_zns\Plugin\Notifier\ZaloZns::$message.
💡 Learn more:
https://phpstan.org/blog/solving-phpstan-access-to-undefined-property
------ --------------------------------------------------------------------------

------ ---------------------------------------------------------------------
Line src/Plugin/rest/resource/ZaloNotificationWebhookResource.php
------ ---------------------------------------------------------------------
61 Call to static method load() on an unknown class
Drupal\message\Entity\Message.
💡 Learn more at https://phpstan.org/user-guide/discovering-symbols
------ ---------------------------------------------------------------------

[ERROR] Found 10 errors

For these applications, we need a project where, in at least the branch used for the application, most of the commits (if not all the commits) have been done from the person who applies.
The purpose of these applications is reviewing a project to understand what the person who applies understands about writing secure code that follows the Drupal coding standards and correctly uses the Drupal API, not to understand what the project maintainers as group understands about those topics.

This application can only continue with another project where most of the commits (and preferable all the commits) have been done by you.

In this case, out of six commits, four commits have been done by lazzyvn.

I am changing priority as per Issue priorities → .

This thread has been idle, in the Needs work state with no activity for several months. Therefore, I am assuming that you are no longer pursuing this application, and I marked it as Closed (won't fix).

If this is incorrect, and you are still pursuing this application, then please feel free to re-open it and set the issue status to Needs work or Needs review, depending on the current status of your code.