- Issue created by @catch
- π¨πSwitzerland berdir Switzerland
Adding this to the meta issue about the conversion (which I think would be a better parent for this, but don't want to just change that).
- π¬π§United Kingdom longwave UK
We need to ensure we document the outcome of π AttributeClassDiscovery fails while trying to include non valid plugin class Fixed , as there are stricter rules for what can exist in the namespace for pure attribute discovery compared to annotations.
- π³πΏNew Zealand quietone
There is an existing page for ' Drupal Plugin Discovery β ' which lists four methods, StaticDiscovery, HookDiscovery, AnnotatedClassDiscovery and YamlDiscovery. That seems like a suitable place to add 'Attribute discovery'. Would that work?
- π³πΏNew Zealand quietone
Added a page for attribute plugins, which is basic and needs work, https://www.drupal.org/docs/drupal-apis/plugin-api/attribute-based-plugins β
- Status changed to Needs review
11 months ago 7:56am 24 January 2024 - Status changed to Postponed: needs info
10 months ago 4:04pm 13 February 2024 - Status changed to Needs work
10 months ago 4:11pm 13 February 2024 - π¬π§United Kingdom longwave UK
I think we should extend the page to include "Using attributes in your own plugin type" similar to the annotations example at https://www.drupal.org/docs/drupal-apis/plugin-api/annotations-based-plu... β
- Status changed to Needs review
10 months ago 2:42am 1 March 2024 - π³πΏNew Zealand quietone
Started the section, Using attributes in your own plugin type β .
- Status changed to RTBC
10 months ago 4:06pm 4 March 2024 - πΊπΈUnited States smustgrave
Reviewing just the section mentioned in #11 change makes sense based on reviews of the attribute tickets.
But question on "Defining a plugin" section.
a key for an optional deriver class
we've been requiring that for attributes so should optional be removed. Either way seemed out of scope for this ticket so maybe a follow up.
- π¬π§United Kingdom catch
The deriver class is optional, the key is not.
- π³πΏNew Zealand quietone
I added another page, Create a custom attribute class β . And that states that the deriver key is required in the Attribute class.
- Status changed to Fixed
9 months ago 9:44am 19 March 2024 - π¬π§United Kingdom catch
I think this is good progress, and we can refine it as time goes on. Eventually we'll need to deprecate and retire the annotations documentation but need to deprecate annotations first and that's still quite far off.
Automatically closed - issue fixed for 2 weeks with no activity.