- Issue created by @fjgarlin
- 🇪🇸Spain fjgarlin
https://git.drupalcode.org/project/project_issue_file_test/-/merge_reque...
Point 1 done. It goes to the edit page, where the only option available is to delete the job.
Point 3 done. Link is hidden and if somebody tries to go directly to the page, there is no button to submit anything.Point 2 left. WIP.
- Status changed to Needs review
11 months ago 11:48am 18 January 2024 - 🇪🇸Spain fjgarlin
Point 2 is implemented now. There is a "delete all" link with a confirmation page available.
Ready to test here:
- Ctools: https://fjgarlin-drupal.dev.devdrupal.org/node/343333/qa
- Core: https://fjgarlin-drupal.dev.devdrupal.org/node/3060/qaMR is ready for review: https://git.drupalcode.org/project/project_issue_file_test/-/merge_reque...
Also, if we set the value of
pift_testing_enabled
to0
, then the "edit" links will change to "remove" and the option to update or add new tests will no longer be available. -
drumm →
committed 638b7037 on 7.x-3.x authored by
fjgarlin →
Issue #3401518: Improve removal of jobs and prevent adding new ones
-
drumm →
committed 638b7037 on 7.x-3.x authored by
fjgarlin →
- 🇺🇸United States drumm NY, US
Deployed, leaving open until we actually prevent adding new scheduled jobs. We can go ahead with 📌 Remove “Automated testing” tab when a project has no DrupalCI testing Active in the meantime.
- 🇺🇸United States drumm NY, US
This is now scheduled for late April 2024 when we can
drush vset pift_testing_enabled 0
and follow up with completely removing the unreachable code. - 🇺🇸United States drumm NY, US
The query to get the maintainers to email, and their projects with active DrupalCI configuration is:
SET group_concat_max_len = 1000000; SELECT vaa.uid, u.name, group_concat(DISTINCT n.title SEPARATOR ', ') FROM pift_ci_project pcp INNER JOIN pift_ci_label_map pclm ON pclm.machine_label = pcp.core_branch AND pclm.status = 1 INNER JOIN field_data_field_release_category fdf_rc_p ON fdf_rc_p.entity_id = pcp.release_nid INNER JOIN field_data_field_release_category fdf_rc_cb ON fdf_rc_cb.entity_id = pcp.release_nid AND fdf_rc_cb.field_release_category_value = fdf_rc_p.field_release_category_value INNER JOIN node n ON n.nid = pcp.nid INNER JOIN versioncontrol_project_projects vpp ON vpp.nid = pcp.nid INNER JOIN versioncontrol_auth_account vaa ON vaa.repo_id = vpp.repo_id AND vaa.access > 0 INNER JOIN users u ON u.uid = vaa.uid AND u.status = 1 WHERE pcp.testing != 'disabled' GROUP BY vaa.uid;
Currently, 2,942 maintainers with 2,731 projects will be emailed.
Next step is to draft that email. Something along the lines of:
Subject: Update your projects to use GitLab CI instead of DrupalCI before July 2024
DrupalCI testing of projects you maintain on Drupal.org will be discontinued in July 2024. Test results will continue to be available for 6 months.
Projects you maintain which currently use DrupalCI are: [list of projects]
GitLab CI is the replacement for automated testing. Resources to help you get started are at:
- https://www.drupal.org/docs/develop/git/using-gitlab-to-contribute-to-dr... →
- https://project.pages.drupalcode.org/gitlab_templates/Starting April 30, you will no longer be able to add or update DrupalCI schedules. For more information, see https://www.drupal.org/project/drupalci/issues/3412417 →
- 🇭🇺Hungary Gábor Hojtsy Hungary
Good draft! I think we should offer interactive help possibilities in the email.
I don't know if a DrupalCon "ad" is appropriate but there will be interactive help there. Something along the lines of "DrupalCon Portland will offer a BoF and contribution day mentoring to help move from DrupalCI to GitLab CI. See https://events.drupal.org/portland2024"
Also should #testing or #gitlab or both be suggested for interactive help before/after the event? Something along the lines of "Discuss any porting challenges, get help and share know-how in the #gitlab and/or #testing channels on Drupal Slack https://www.drupal.org/slack → "
Finally I would make July explicit with July 1st :)
- 🇺🇸United States drumm NY, US
I sent a test email, adding in Gábor’s suggestions, and changing the URLs to links. One last change before sending is changing BoF to avoid jargon.
- 🇺🇸United States drumm NY, US
That has been sent. Currently there are 2,932 maintainers of 2,724 projects with DrupalCI.
- Status changed to RTBC
8 months ago 8:07pm 1 May 2024 - 🇺🇸United States drumm NY, US
Testing schedules can no longer be added. We can now remove any code gated by
pift_testing_enabled
, so we don’t have to look at it again as we discontinue the rest of testing with #3412417: Disable DrupalCI testing → - Status changed to Fixed
8 months ago 10:04pm 2 May 2024 Automatically closed - issue fixed for 2 weeks with no activity.