FileUrlGenerator and stream wrapper create broken URLs in kernel tests

Created on 13 November 2023, over 1 year ago

Problem/Motivation

The following kernel test code:

    $this->container->get('file_system')->copy($this->root . '/core/misc/druplicon.png', 'public://druplicon.png');
    $image_file = $this->entityTypeManager->getStorage('file')->create([
      'uri' => 'public://druplicon.png',
    ]);
    $image_file->save();

    dump($image_file->getFileUri());
    dump($image_file->createFileUrl(FALSE));
    dump($image_file->createFileUrl());

produces this output:

"public://druplicon.png"

"http://localhost/vfs://root/sites/simpletest/86401788/files/druplicon.png"

"/vfs://root/sites/simpletest/86401788/files/druplicon.png"

The last two values look wrong.

Steps to reproduce

Proposed resolution

Remaining tasks

User interface changes

API changes

Data model changes

Release notes snippet

🐛 Bug report

Status

Active

Version

11.0 🔥

Component

File system →

Last updated about 2 hours ago

Maintained by
🇦🇺Australia @kim.pepper

Created by

🇬🇧United Kingdom joachim

Live updates comments and jobs are added and updated live.

Comments & Activities

Issue created by @joachim
Comment over 1 year ago →
🇬🇧United Kingdom joachim
It's worth noting though that in kernel tests, Settings::get('file_public_path', '') also returns the vfs prefix, and so removing the public file path from the URI makes everything work in the end.

It's still really weird though.
Comment over 1 year ago →
🇮🇳India pradhumanjainOSL
@joachim would you please explain what we need to do here.
Comment over 1 year ago →
🇬🇧United Kingdom joachim
The URLs aren't valid URLs, are they?
Comment 3 days ago →
🇺🇸United States smustgrave
Came up as a daily BSI target

Still need to verify if still a problem, but am tagging for IS because if it is will need to complete the IS.

contrib.social Blog FAQ Discussions

Production build 0.71.5 2024