Drupal 10 follow-up

CONTRIBUTED PROJECTS -------------------------------------------------------------------------------- YASM 2.0.4 Scanned on Mon, 11/13/2023 - 11:09. 1 error found. 2 warnings found. web/modules/contrib/yasm/modules/yasm_charts/src/Services/YasmChartsBuilder.php: ┌─────────┬──────┬────────────────────────────────────────────────────────────┐ │ STATUS │ LINE │ MESSAGE │ ├─────────┼──────┼────────────────────────────────────────────────────────────┤ │ Fix now │ 165 │ Call to deprecated method toInt() of class │ │ │ │ Drupal\Component\Utility\Bytes. Deprecated in drupal:9.1.0 │ │ │ │ and is removed from drupal:10.0.0. Use │ │ │ │ Drupal\Component\Utility\Bytes::toNumber() instead │ │ │ │ │ └─────────┴──────┴────────────────────────────────────────────────────────────┘ web/modules/contrib/yasm/src/Controller/Users.php: ┌──────────┬──────┬──────────────────────────────────────────────────────────────┐ │ STATUS │ LINE │ MESSAGE │ ├──────────┼──────┼──────────────────────────────────────────────────────────────┤ │ Check │ 325 │ Relying on entity queries to check access by default is │ │ manually │ │ deprecated in drupal:9.2.0 and an error will be thrown from │ │ │ │ drupal:10.0.0. Call │ │ │ │ \Drupal\Core\Entity\Query\QueryInterface::accessCheck() with │ │ │ │ TRUE or FALSE to specify whether access should be checked. │ │ │ │ │ └──────────┴──────┴──────────────────────────────────────────────────────────────┘ web/modules/contrib/yasm/modules/yasm_charts/yasm_charts.info.yml: ┌──────────┬──────┬────────────────────────────────────────────────────────────┐ │ STATUS │ LINE │ MESSAGE │ ├──────────┼──────┼────────────────────────────────────────────────────────────┤ │ Check │ 0 │ Value of core_version_requirement: ^8 || ^9 is not │ │ manually │ │ compatible with the next major version of Drupal core. See │ │ │ │ https://drupal.org/node/3070687. │ │ │ │ │ └──────────┴──────┴────────────────────────────────────────────────────────────┘

Comments & Activities

Issue created by @Taran2L
Open in Jenkins → Open on Drupal.org →
Core: 9.5.x + Environment: PHP 7.4 & MySQL 8
last update 11 months ago
3 pass, 1 fail
@taran2l opened merge request.
Comment 11 months ago →
🇺🇦Ukraine Taran2L Lviv
Open in Jenkins → Open on Drupal.org →
Core: 10.1.x + Environment: PHP 8.2 & sqlite-3.34
last update 11 months ago
6 fail
Status changed to Needs review 11 months ago10:29am 13 November 2023
Comment 11 months ago →
🇺🇦Ukraine Taran2L Lviv
Please review the MR.

Two major changes there:

Bump minimal supported version to 9.4, change Bytes::toInt => Bytes::toNumber requires 9.1 (so won't work with D8 anyways), but there is no point to make 9.1, as the minimum upgradable to D10 version is 9.4

Added access check to the users controller, maybe it should be false
Open in Jenkins → Open on Drupal.org →
Core: 9.5.x + Environment: PHP 7.4 & MySQL 8
last update 11 months ago
2 pass, 3 fail
Open in Jenkins → Open on Drupal.org →
Core: 9.5.x + Environment: PHP 7.4 & MySQL 8
last update 11 months ago
4 pass
Open in Jenkins → Open on Drupal.org →
Core: 10.1.x + Environment: PHP 8.2 & sqlite-3.34
last update 11 months ago
4 pass
Open in Jenkins → Open on Drupal.org →
Core: 9.5.x + Environment: PHP 7.4 & MySQL 8
last update 11 months ago
4 pass
Open in Jenkins → Open on Drupal.org →
Core: 9.5.x + Environment: PHP 7.4 & MySQL 8
last update 11 months ago
4 pass
Open in Jenkins → Open on Drupal.org →
Core: 10.1.x + Environment: PHP 8.2 & sqlite-3.34
last update 11 months ago
4 pass
Open in Jenkins → Open on Drupal.org →
Core: 9.5.x + Environment: PHP 7.4 & MySQL 8
last update 11 months ago
4 pass
Open in Jenkins → Open on Drupal.org →
Core: 9.5.x + Environment: PHP 7.4 & MySQL 8
last update 11 months ago
Patch Failed to Apply
Comment 11 months ago →
🇺🇦Ukraine Taran2L Lviv
Static patch for those who wants to apply it on top of the stable version
Open in Jenkins → Open on Drupal.org →
Core: 9.5.x + Environment: PHP 7.4 & MySQL 8
last update 11 months ago
4 pass
Comment 11 months ago →
🇺🇦Ukraine Taran2L Lviv
This is a proper static patch (applies to stable 2.0.4)
Open in Jenkins → Open on Drupal.org →
Core: 10.1.x + Environment: PHP 8.2 & sqlite-3.34
last update 11 months ago
4 pass
Comment 7 months ago →
System Message

oriol_e9g → committed 0a691e93 on 2.0.x
Issue #3401187 by Taran2L: Drupal 10 follow-up
Status changed to Fixed 7 months ago3:51pm 5 March 2024
Comment 7 months ago →
🇪🇸Spain oriol_e9g Barcelona
Comment 6 months ago →
System Message
Automatically closed - issue fixed for 2 weeks with no activity.

Problem/Motivation

Steps to reproduce

Proposed resolution

Remaining tasks

User interface changes

API changes

Data model changes

Comments & Activities