GinNavigation implements ContainerInjectionInterface but doesn't actually do any dependency injection

Created on 12 November 2023, 7 months ago

Updated 15 May 2024, about 1 month ago

Problem/Motivation

Title sums it up. Anyone mind if I tackle this and open a merge request?

Steps to reproduce

Lot of accessing the \Drupal static global and various static calls to stuff like BlockContentType::loadMultiple(), Vocabulary::loadMultiple(), etc., which are completely unnecessary since we have direct access to the container.

https://git.drupalcode.org/project/gin/-/blob/233700f678b77049d547213305...

Proposed resolution

See above.

Remaining tasks

Do the thing.

User interface changes

None.

API changes

None.

Data model changes

None.

📌 Task

Status

Closed: duplicate

Version

3.0

Component

Code

Created by

🇨🇦Canada Ambient.Impact Toronto

Live updates comments and jobs are added and updated live.

Comments & Activities

Issue created by @Ambient.Impact
Status changed to Postponed 7 months ago1:52pm 13 November 2023
Comment 7 months ago →
🇨🇭Switzerland saschaeggi Zurich
I'm moving this to postponed for now as first we need to rebase the current implementation with the changes from upstream in a next step.
Status changed to Closed: duplicate about 1 month ago8:03am 15 May 2024
Comment about 1 month ago →
🇨🇭Switzerland saschaeggi Zurich
Closing as duplicate of https://www.drupal.org/project/gin/issues/3395897 📌 Use dependency injection in GinNavigation.php Needs review

contrib.social Blog FAQ Discussions

Production build 0.69.0 2024