Contrib.social

[D10.1] Embed button CKEditor5 compatiblity

Open on Drupal.org →
Created on 10 November 2023, about 1 year ago
Updated 14 November 2023, about 1 year ago

Problem/Motivation

I just had a look at the Status Report (/admin/reports/status) and I am seeing the following error:

Embed button CKEditor5 compatiblity
The following embed button(s) are not using SVG icons and will not be compatible with CKEditor5
Node: /modules/contrib/entity_embed/js/plugins/drupalentity/entity.png
URL: /modules/contrib/url_embed/js/plugins/drupalurl/urlembed.png

Steps to reproduce

Have a look at the Status Report (/admin/reports/status), you'll see that error above

Proposed resolution

CKEditor5 only supports SVGs for the embed icons. If a user uploads an image for the icon which is not in an SVG format, it will not show up on the toolbar for CKEditor5.

The icons for these buttons can be changed here:

/admin/config/content/embed/button/manage/node
/admin/config/content/embed/button/manage/url

It would be nice to have these as SVG by default.

For the entity_embed module, the latest entity_embed module fixes this: https://www.drupal.org/project/entity_embed/releases/8.x-1.5 →

For the url_embed module, there is a potential patch for that (which I haven't tested yet): https://www.drupal.org/files/issues/2023-05-18/url_embed_ckeditor5_suppo... →

Remaining tasks

User interface changes

API changes

Data model changes

🐛 Bug report
Status

Fixed

Version

5.0

Component

Code

Created by

🇨🇦Canada danrod Ottawa

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Comments & Activities

  • Issue created by @danrod
  • Comment about 1 year ago →
    🇨🇦Canada danrod Ottawa

    Also, I am having an issue when trying to upgrade entity_embed from 1.4 to 1.5, this only happens when doing the upgrade, there is an issue for that here: https://www.drupal.org/project/entity_embed/issues/3400550 💬 Updating to 1.5 crashes website due to duplicated method in .module file. Postponed: needs info

  • Comment about 1 year ago →
    🇨🇦Canada smulvih2 Canada 🍁

    @danrod, depending on the branch you are using for WxT, you might need to add the entity_embed patch to the patches-ignore section of composer. We just recently removed this patch since the CKE5 compatibility is now available in entity_embed 1.5. This patch is probably adding the double function that is causing your issue.

  • Comment about 1 year ago →
    🇨🇦Canada smulvih2 Canada 🍁

    @danrod I'm looking at this now in my local, and it only complains about the URL button, not the Node button. The node button uses an SVG "E" on a default install of WxT. Maybe you are getting this error based on issue with applying the patch?

  • Status changed to Fixed about 1 year ago
  • Comment about 1 year ago →
    🇨🇦Canada smulvih2 Canada 🍁

    This has been fixed in the 5.1.x branch. Added a config rewrite to make the URL icon an SVG. Now this error is no longer seen on the status page.

contrib.social Blog FAQ Discussions
Production build 0.71.5 2024