Text color changes on hover for <a> elements with .buttons

Adding back the styling to the button.css that was previously removed.

Reviewed code and tested UI for merge request !5330 from #4, it works nicely now.

lauriii → closed merge request !5330

Committed 1f9f444 and pushed to 11.x. Also cherry-picked to 10.2.x. Thanks!

I've noticed some odd behavior on the primary blue buttons for example on /admin/structure/block-content the button looks like the following on hover:

the button label color on hover is var(--button-fg-color) #232429 and the background color var(--button--hover-bg-color--primary) #0036b1 which leads to a color contrast of 1.6:1, WCAG SC 1.4.3 requires 4.5:1 . I've noticed the issue on an install of 11.0-dev tonight for the first time. some digging brought me to this issue. i comment on the issue or would the better approach be to open a new issue?

Good catch @rkoller! It seems simple enough fix that we can commit the follow-up from here. I opened a new MR to reduce the selector specificity which should address that regression.

The Needs Review Queue Bot → tested this issue. It fails the Drupal core commit checks. Therefore, this issue status is now "Needs work".

This does not mean that the patch needs to be re-rolled or the MR rebased. Read the Issue Summary, the issue tags and the latest discussion here to determine what needs to be done.

Consult the Drupal Contributor Guide → to find step-by-step guides for working with issues.

I've applied your changes and i can confirm the regression is fixed. thank you!

and one other detail. on second thought after posting my initial comment i realized that this issue 📌 Automated A11y tests in Nightwatch Fixed got into 10.1. my assumption was that those automated tests would catch that kind of low hanging fruit like a low color contrast in the course of the CI process. but then learned after having a brief chat with @mikegifford that the tests got in place with an initial set of pages checked. out of the scope for this issue but would it make sense going forward in case a a11y issue is being noticed to extend the set of tests for nightwatch that the case currently failing is covered the next time?

Addressed the CSS lint issue. Moving back to needs review but there should be no functional changes since #17.

#17: This is being discussed in 📌 [PP-1] Consider updating core gates to include automated Nightwatch A11y tests Postponed . Feel free to chime in there! 😊

retested with the latest changes from commit 0532cd98. still the same output and result as you suspected. looks good to go.

and thanks for the link! will take look now.

lauriii → closed merge request !5342

Committed e051b9c and pushed to 11.x. Also cherry-picked to 10.2.x. Thanks!

Automatically closed - issue fixed for 2 weeks with no activity.