Incorrect converting the comma-separated emails into Address class

I'll work on it

Should be fixed by using reroute_email_extract_addresses() when setting cc/bcc/to recipients. Please review.

Updating issue metadata

Hi @quadrexdev,
thanks for your contribution!

1) reroute_email_extract_addresses function is located in the module files as a legacy artifact.
Let's move it as a method to RerouteEmailHandlerPluginBase (this is the only place where it is used).

2) We should cover this bug with a test. There is MultipleRecipientsTest for hook_mail_alter implementation.
This test should be added to reroute_email_symfony_mailer tests.

Thanks!

Thanks for your help @bohart!

I guess now it's ready for the review.

A summary of what was done:

1. The reroute_email_extract_addresses function is moved as the extractEmailAddresses method in the new trait - RerouteEmailHelpers.
2. All to/cc/bcc-related functions use the extractEmailAddresses method to process addresses.
3. New test - SymfonyMailerMultipleRecipientsTest.
4. Associative array keys are used for datasets in SymfonyMailerTestEmailFormTest (so it's easier to find problematic places in case the test fails).
5. New test - InvalidAddressesTest.
6. Updated tests that were failing because of spaces between e-mail addresses in the string. F.e - link.
7. Added clearing of mail collector state due to the following error:

1) Drupal\Tests\reroute_email_symfony_mailer\Functional\SymfonyMailerMultipleRecipientsTest::testMultipleRecipients
All emails have been checked.
Failed asserting that actual size 1 matches expected size 0.

Explained here - link.

I do believe it should be moved to the issues queue of Symfony mailer to add support for multiple e-mails in the collector state.

@quadrexdev, thanks for your contribution!
Committed to 2.3.x dev branch. It will be a part of the next 2.3 series releases.

We will also need to handle a new test InvalidAddressesTest for Symfony Mailer submodule,
but it will be a part of 📌 SymfonyMailerTestEmailFormTest skipped 6 tests to run Active .

Thanks!

Automatically closed - issue fixed for 2 weeks with no activity.