- Issue created by @dimitriskr
- Merge request !30Update setup.sql. Remove "create user" statement #3399858 → (Merged) created by dimitriskr
- 🇪🇸Spain fjgarlin
I see that the approach taken in the "mysql" images is different, where the commands to create the user and flush priviledges is done in the startup.sh script. "mariadb" images follow a different approach, so I wonder if the user is created at all.
- 🇫🇷France andypost
Let's unify the approach, I think pgsql images makes sense to check as well as they were the last anybody touch
- 🇬🇷Greece dimitriskr
Core tests still pass with the new approach.
As discussed in a Slack thread, no changes will take place at MariaDB 10.2 version yet - 🇪🇸Spain fjgarlin
@dimitriskr - is this ready for review or are you planning to do some more work here?
- Status changed to Needs review
about 1 year ago 11:43am 15 November 2023 - 🇪🇸Spain fjgarlin
The refactoring looks good to me, but probably @andypost will be better positioned to fully review and merge this.
As soon as it's merged to "dev" or "prod" images, we can test the core issue. Thanks! - 🇬🇷Greece dimitriskr
@andypost, shall we unify the approaches of all DBs here on this issue, or create a follow-up?
- 🇬🇧United Kingdom catch
For me I think we should do the consolidation in a follow-up. This will allow us to switch off more DrupalCI jobs, and bring us closer to being able to shut it down (for core testing at least) altogether.
- 🇫🇷France andypost
It looks good to me but I have no ability to test/merge it in next 2 days
Probably I need to squash commits via Gitlab to simplify cherry-picking to production branch
- 🇪🇸Spain fjgarlin
Just following up. Any update on this? If it gets merged to
dev
we'd be able to further review and test here 📌 [GitlabCI] MariaDB currently not working Fixed . -
andypost →
committed 176e3dac on dev authored by
dimitriskr →
MariaDB 10.3.22 - remove "create user" statement #3399858
-
andypost →
committed 176e3dac on dev authored by
dimitriskr →
- Status changed to RTBC
about 1 year ago 10:20pm 23 November 2023 - 🇫🇷France andypost
Merged to dev so it can be tested as pipeline passed https://git.drupalcode.org/project/drupalci_environments/-/commit/176e3d...
-
andypost →
committed c05528c8 on dev authored by
dimitriskr →
MariaDB 10.3.22 - remove "create user" statement #3399858
-
andypost →
committed c05528c8 on dev authored by
dimitriskr →
- Status changed to Needs work
about 1 year ago 10:29pm 23 November 2023 - 🇫🇷France andypost
The issue is that repository changed https://mariadb.org/download/?t=repo-config&d=18.04+LTS+%22bionic%22&v=1...
-
andypost →
committed 35797df4 on dev authored by
dimitriskr →
MariaDB 10.3.22 - remove "create user" statement #3399858
-
andypost →
committed 35797df4 on dev authored by
dimitriskr →
- Status changed to RTBC
about 1 year ago 10:49pm 23 November 2023 - 🇫🇷France andypost
Looks now it working https://git.drupalcode.org/issue/drupal-3385621/-/pipelines/54549
the issue hew is that the image no longer maintained(
-
andypost →
committed 1038da61 on production authored by
dimitriskr →
MariaDB 10.3.22 - remove "create user" statement #3399858 (cherry...
-
andypost →
committed 1038da61 on production authored by
dimitriskr →
- Status changed to Fixed
about 1 year ago 11:29pm 23 November 2023 - 🇫🇷France andypost
Pushed production image https://git.drupalcode.org/project/drupalci_environments/-/jobs/387237
Core's pipeline https://git.drupalcode.org/issue/drupal-3385621/-/pipelines/54560
Automatically closed - issue fixed for 2 weeks with no activity.