Can we replace "grid_layout" with "generic_layout" ?

Created on 6 November 2023, 8 months ago
Updated 15 November 2023, 8 months ago

The module doesn't seem to work at the section creation level... (although the grid creation form is much better than the "grid_layout" module)
when you click on the section creation button, an "500 internal error" and return.

🐛 Bug report
Status

Fixed

Version

1.0

Component

Code

Created by

🇫🇷France steveoriol Grenoble 🇫🇷

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Comments & Activities

  • Issue created by @steveoriol
  • 🇩🇪Germany TomSaw Essen

    Thanks a lot for testing @steveoriol!

    This modules code is quite sophiusticated and i've not yet tested it on other machines than my laptop and my linux server.
    To understand and fix this bug, please provide me with more information:

    Could you please copy&paste the full content of Drupal.AjaxError visible on the very bottom of your screenshot!

    Thanks :)

  • Status changed to Postponed: needs info 8 months ago
  • 🇩🇪Germany TomSaw Essen

    because of your title

    "Can we replace "grid_layout" with "generic_layout"

    The topic would be better covered in another issue but anyways:

    I've tried to contact the maintainer of grid_layout a few times. With no success... 😥

    There's a protocol to take ownership of modules but I'm not in the mood to acquire for it. Also generic_layout's storage scheme is different to grid_layout ones. It would require various update hooks, hence even more administration on top.

    Let's get generic_layout stable first an see, what time brings.

  • 🇩🇪Germany TomSaw Essen

    Holla... Think I could fix the bug without further information.
    Please update generic_layout and give it a new try @steveoriol!

  • Status changed to Needs review 8 months ago
  • 🇩🇪Germany TomSaw Essen

    I'm 99% sure this bug is solved (after a ton of improvements) so I close this.
    Don't hesitate to open a new issue if not.

  • Assigned to TomSaw
  • Status changed to Fixed 8 months ago
  • 🇫🇷France steveoriol Grenoble 🇫🇷

    Hello TomSaw,

    Sorry, but I try to update "composer require 'drupal/generic_layout:^1.0@RC'", and now, pages like "node/x/layout" show an 500 error.
    error message is :
    Symfony\Component\Routing\Exception\InvalidParameterException : Parameter "region" for route "layout_builder.choose_block" must match "[^/]++" ("" given) to generate a corresponding URL. dans Drupal\Core\Routing\UrlGenerator->doGenerate() (ligne 203 de /var/www/jpjformation/web/core/lib/Drupal/Core/Routing/UrlGenerator.php).

    and, when I try to uninstall the module, it also fails.
    when, I try with drush commande "drush pmu generic_layout", I get :

     [error]  Error: Call to undefined method Drupal\generic_layout\GenericLayoutManager::reset() in generic_layout_uninstall() (line 14 of /var/www/jpjformation/web/modules/contrib/generic_layout/generic_layout.install) #0 [internal function]: generic_layout_uninstall()
    #1 /var/www/jpjformation/web/core/lib/Drupal/Core/Extension/ModuleHandler.php(417): call_user_func_array()
    #2 /var/www/jpjformation/web/core/lib/Drupal/Core/Extension/ModuleInstaller.php(467): Drupal\Core\Extension\ModuleHandler->invoke()
    #3 /var/www/jpjformation/web/core/lib/Drupal/Core/ProxyClass/Extension/ModuleInstaller.php(91): Drupal\Core\Extension\ModuleInstaller->uninstall()
    #4 /var/www/jpjformation/vendor/drush/drush/src/Drupal/Commands/pm/PmCommands.php(177): Drupal\Core\ProxyClass\Extension\ModuleInstaller->uninstall()
    #5 [internal function]: Drush\Drupal\Commands\pm\PmCommands->uninstall()
    #6 
    [...]
     [warning] Drush command terminated abnormally.
    
  • 🇩🇪Germany TomSaw Essen

    You've installed a development version in production?

    That's never a good idea: code changes may break your side as happened here. Always and only use releases in production!

    Anyways, let's fix that:
    -

    A clean way is to get rid of the dev generic_layout and do a fresh install of the release candidate. I think that's what you've tried too.

    To get rid of the error on uninstall, please remove the function 'generic_layout_uninstall' from generic_layout.module. It only deletes the generated css files in 'public://' folder.

    Do a "drush cache:rebuild" afterwards and now the uninstall "drush pmu generic_layout" should work.

    Now update to the RC and install it.
    -
    I'm quite sure, there's a second step, cause you may still have the depricated configs from generic_layout in your entities.

    Please, could you post me the follow up error message as well, so I can help as best as I can!

  • 🇫🇷France steveoriol Grenoble 🇫🇷

    I need to create the "generic_layout" folder by hand,
    and to remove the module I need to edit the "generic_layout.install" file and delete the "generic_layout_uninstall" function.
    Note:
    is it normal that there is a function named "generic_layout_uninstal" with one "l" in the "generic_layout.module" file?

  • 🇩🇪Germany TomSaw Essen


    I need to create the "grid_layout" folder by hand

    Under which circumstances do you have to create this for by hand? On installation?

    to remove the module I need to edit the "generic_layout.install" file and delete the "generic_layout_uninstall" function.

    Usually, the module should require touching the code. The measure, proposed in my previous comment, is required to fix your site because you've installed a development version of the module. It contains mad or discarded code which was not intended to be used by end users / in production (This developement). Usually, developers use developement versions only in test environments! drupal.org also prints a warning on the bottom of modules pages.
    When you're using composer, to be on the safe side you may want to disallow composer to install dev versions of modules. In composer.jsom there's a parameter called "prefer-stable" of "minimum-stability" if I memorize this correctly.

    -

    Oh and you're right .. it must be generic_layout_uninstall. with double 'l'. Thanks for that

  • Automatically closed - issue fixed for 2 weeks with no activity.

Production build 0.69.0 2024