- Issue created by @sanduhrs
-
sanduhrs ā
committed 3b498514 on 2.0.x
Issue #3399331 by sanduhrs: Fix phpcs
-
sanduhrs ā
committed 3b498514 on 2.0.x
-
sanduhrs ā
committed a3eb3114 on 2.0.x
Issue #3399331 by sanduhrs: Fix phpcs
-
sanduhrs ā
committed a3eb3114 on 2.0.x
- Assigned to chetan 11
- Issue was unassigned.
- š®š³India chetan 11
Hi
I have fixed the phpcs issues in above module, please check the attached MR.
Thanks - Status changed to Needs review
over 1 year ago 1:06pm 6 November 2023 - Status changed to Needs work
over 1 year ago 4:53am 7 November 2023 - šµšPhilippines clarkssquared
Hi chetan 11,
"The issue summary should always describe what the issue is trying to fix and, in the case, of coding standards issues, show which command has been used, which arguments have been used, and which report that command shown."- Comment #3 š Fix the issues reported by phpcs Fixed
Please add more information regarding the issue
- š®š³India chetan 11
use this command to find the issues, where listed for phpcs.
./vendor/bin/phpcs --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,css,info,txt,md,yml,twig,js - Status changed to Needs review
over 1 year ago 7:25am 7 November 2023 - šµšPhilippines clarkssquared
Hi chetan,
I applied your MR !7 and I confirmed that it fixes all the PHPCS issues, however, I will remain the status to needs review so that other user can also share their feedback regarding your MR.
ā clipboardjs git:(2.0.x) curl https://git.drupalcode.org/project/clipboardjs/-/merge_requests/7.diff | patch -p1 % Total % Received % Xferd Average Speed Time Time Time Current Dload Upload Total Spent Left Speed 100 5169 0 5169 0 0 9428 0 --:--:-- --:--:-- --:--:-- 9572 patching file README.md patching file clipboardjs.module patching file 'src/Commands/ClipboardJsCommands.php' ā clipboardjs git:(2.0.x) ā .. ā contrib git:(master) ā phpcs --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,css,info,txt,md,yml clipboardjs ā contrib git:(master) ā
- š®š³India Yashaswi18
Hello, I checked out to the branch and ran the phpcs command, found no errors or warnings remaining. RTBC +1.
- Status changed to RTBC
about 1 year ago 7:22am 14 March 2024 - š§šŖBelgium tim-diels Belgium š§šŖ
This MR does more then needed so going to close it. Will credit for the work done though.
Will add new smaller MR with only Drupal CS and not DrupalPractise, that should be handled differently. - Assigned to tim-diels
- Status changed to Needs work
2 months ago 2:23pm 29 January 2025 -
tim-diels ā
committed 2d396aaa on 2.0.x
Issue #3399331 by tim-diels, chetan 11, sanduhrs: Fix phpcs
-
tim-diels ā
committed 2d396aaa on 2.0.x
Automatically closed - issue fixed for 2 weeks with no activity.