- Issue created by @saidatom
- @saidatom opened merge request.
- Status changed to Needs review
about 1 year ago 11:45pm 3 November 2023 - Status changed to Postponed
about 1 year ago 12:22am 4 November 2023 - 🇺🇸United States smustgrave
Think this should be postponed till 📌 Adopt friendsoftwig/twigcs for Twig coding standards Needs review lands. Or we could just keep having these come back.
- Status changed to Needs review
about 1 year ago 12:24am 4 November 2023 - 🇺🇸United States smustgrave
Actually opposite, think the other should be postponed.
- Status changed to RTBC
about 1 year ago 4:41pm 7 November 2023 - 🇺🇸United States smustgrave
Applied the changes from 📌 Adopt friendsoftwig/twigcs for Twig coding standards Needs review and ran the php vendor/bin/twig-cs-fixer lint > twig-cs-quality-report.json
Got 120+ errors
Applied the MR here and reran the script. Got [OK] Files linted: 876, notices: 0, warnings: 0, errors: 0
Marking this but don't know if it's held up by 📌 Adopt friendsoftwig/twigcs for Twig coding standards Needs review being approved. But 3284817 will be blocked till this lands.
Cleaned up issue summary some.
- Status changed to Fixed
about 1 year ago 12:31pm 8 November 2023 - 🇫🇮Finland lauriii Finland
Usually we require the linting to be introduced first to ensure we don't regress. Since the linting is already well on it's way and we can see there's plenty of easy to review violations, seems fine to commit this before 📌 Adopt friendsoftwig/twigcs for Twig coding standards Needs review since it will make it easier to land that.
Committed 2e792db and pushed to 11.x. Also cherry-picked to 10.2.x. Thanks!
Automatically closed - issue fixed for 2 weeks with no activity.