PHP 8.2 support

Using the patch has stopped deprecation warnings on my local instances when using PHP 8.2. Nice work!

I can confirm that typogrify on PHP 8.2 has deprecation warnings. I tested this patch on a fresh site install running PHP 8.2.

• All of the warning have disappeared.
• Reviewing code - all changes are consistant with other recent deprecation fixes.
• I functionally tested that Typogrify is replacing my hyphens with m-dashes as expected.
• Local tests are passing.
• Added automated test on this merge request for PHP8.2/MySQL8/D10.1 and the change passes.

This all looks good to me. Indicating this is reviewed and tested by community.

Tested on 8.2 and it made the deprecation warnings go away.

Thanks!

Typogrify 1.3 seems to include this change, apart from the change to src/Plugin/Filter/TypogrifyFilter.php, which is handled slightly differently.

It doesn't seem to be mentioned in the release notes, and the MR is still open, but I think this issue can be marked Fixed.

In Typogrify 1.2 as well as 1.3 our watchdog is still being overwhelmed with the messages:

"Deprecated function: Use of "static" in callables is deprecated in Drupal\typogrify\Typogrify::initialQuotes() (line 168 of (...)/web/modules/contrib/typogrify/src/Typogrify.php) "

Drupal version 10.1.5, PHP 8.2.7

I think just the second commit in MR !6 will fix the deprecation notices mentioned in #8. I prefer a simpler MR that fixes actual problems.

In the long term, I would like to replace all of these files (unchanged from the 7.x version of this module) with packages imported using Composer. Let someone else maintain them and then I just have to maintain the Drupal code.

Since that is the long-term plan, I do not want to make changes to those files unless they fix actual problems.

One of the changes does not apply to Typogrify 1.3. That is one reason to avoid large MRs with changes that are not essential. Back to NW.

I enabled GitLab CI for testing in 📌 Move automated tests to GitLab CI Fixed . That should make it easier to confirm what I said about PHPStan.

ambient.impact → made their first commit to this issue’s fork.

I merged in the latest 8.x-1.x changes, i.e. up to 8.x-1.4-rc1 ;)

@joachim: Thanks for checking.

@ambient.impact: Thanks for updating the MR. But what I really want is a simpler MR, as I said in Comment #9.

I am leaving the status at NW.