- Issue created by @vinmassaro
- last update
8 months ago 5 pass - Status changed to Needs review
8 months ago 8:16pm 2 November 2023 - last update
8 months ago 5 pass - last update
8 months ago 5 pass - 🇺🇸United States dblanken
Using the patch has stopped deprecation warnings on my local instances when using PHP 8.2. Nice work!
- last update
7 months ago Composer require failure - Open in Jenkins → Open on Drupal.org →Core: 10.1.x + Environment: PHP 8.2 & MySQL 8 (--ignore-platfrom-reqs)last update
7 months ago 5 pass - Status changed to RTBC
7 months ago 4:36pm 17 November 2023 - 🇺🇸United States nJim
I can confirm that typogrify on PHP 8.2 has deprecation warnings. I tested this patch on a fresh site install running PHP 8.2.
- All of the warning have disappeared.
- Reviewing code - all changes are consistant with other recent deprecation fixes.
- I functionally tested that Typogrify is replacing my hyphens with m-dashes as expected.
- Local tests are passing.
- Added automated test on this merge request for PHP8.2/MySQL8/D10.1 and the change passes.
This all looks good to me. Indicating this is reviewed and tested by community.
- 🇮🇪Ireland lostcarpark
Tested on 8.2 and it made the deprecation warnings go away.
Thanks!
- 🇮🇪Ireland lostcarpark
Typogrify 1.3 seems to include this change, apart from the change to
src/Plugin/Filter/TypogrifyFilter.php, which is handled slightly differently.It doesn't seem to be mentioned in the release notes, and the MR is still open, but I think this issue can be marked Fixed.
- 🇨🇿Czech Republic my-family
In Typogrify 1.2 as well as 1.3 our watchdog is still being overwhelmed with the messages:
"Deprecated function: Use of "static" in callables is deprecated in Drupal\typogrify\Typogrify::initialQuotes() (line 168 of (...)/web/modules/contrib/typogrify/src/Typogrify.php) "
Drupal version 10.1.5, PHP 8.2.7
- Status changed to Needs work
6 months ago 4:30am 16 January 2024 - 🇺🇸United States benjifisher Boston area
I think just the second commit in MR !6 will fix the deprecation notices mentioned in #8. I prefer a simpler MR that fixes actual problems.
In the long term, I would like to replace all of these files (unchanged from the 7.x version of this module) with packages imported using Composer. Let someone else maintain them and then I just have to maintain the Drupal code.
Since that is the long-term plan, I do not want to make changes to those files unless they fix actual problems.
One of the changes does not apply to Typogrify 1.3. That is one reason to avoid large MRs with changes that are not essential. Back to NW.
- 🇺🇸United States benjifisher Boston area
I enabled GitLab CI for testing in 📌 Move automated tests to GitLab CI Fixed . That should make it easier to confirm what I said about PHPStan.