- Issue created by @Panchuk
- Assigned to chetan 11
- Issue was unassigned.
- Status changed to Needs review
about 1 year ago 6:46am 2 November 2023 - š®š³India chetan 11
Hi Panchuk
I have fixed all the phpcs issues in "Layout Builder Lock" module.
please check the raised MR.
Thanks - Status changed to Needs work
about 1 year ago 8:51am 2 November 2023 - šŗš¦Ukraine Panchuk Volyn, Lutsk
Hey @chatan-11
Thanks for your contribution! I reviewed MR and found a few problems.
PHPCS still failed in the layout_builder_lock.module file.
https://git.drupalcode.org/issue/layout_builder_lock-3398496/-/jobs/264738| Hook implementations should not duplicate @param
| documentation
| (Drupal.Commenting.HookComment.HookParamDoc)These errors mean that the doc for hooks shouldn't contain any @param or @return props.
Example:
/**
* Implements hook_element_info_alter().
*/ - Status changed to Needs review
about 1 year ago 1:16pm 2 November 2023 - Status changed to RTBC
about 1 year ago 5:39am 3 November 2023 - šµšPhilippines clarkssquared
Hi chetan,
I applied your updated MR !16 into my local and as I execute the PHPCS command its now flagged no PHPCS issues in the module
ā layout_builder_lock git:(4e0e049) curl https://git.drupalcode.org/project/layout_builder_lock/-/merge_requests/16.diff | patch -p1 % Total % Received % Xferd Average Speed Time Time Time Current Dload Upload Total Spent Left Speed 100 27084 0 27084 0 0 49795 0 --:--:-- --:--:-- --:--:-- 51984 patching file README.md patching file 'js/layout-builder-lock.admin.js' patching file layout_builder_lock.module patching file 'src/Access/LayoutBuilderLockAccessCheck.php' patching file 'src/LayoutBuilderLock.php' patching file 'tests/src/Functional/LayoutBuilderLockTest.php' ā layout_builder_lock git:(4e0e049) ā .. ā contrib git:(master) ā phpcs --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,css,info,txt,md,yml layout_builder_lock ā contrib git:(master) ā
- š®š³India chetan 11
I have changed all the things as per the mention in comments.
-
Panchuk ā
committed 75a5257f on 8.x-1.x authored by
chetan 11 ā
Issue #3398496 by chetan 11, Panchuk, clarkssquared: Fix PHPCS warnings
-
Panchuk ā
committed 75a5257f on 8.x-1.x authored by
chetan 11 ā
- Status changed to Fixed
12 months ago 7:47pm 27 November 2023 Automatically closed - issue fixed for 2 weeks with no activity.