- Issue created by @johnpicozzi
- Assigned to Shreya_98
- Issue was unassigned.
- 🇮🇳India Shreya_98
Hi @johnpicozzi,
I have fixed this issue . kindly review the patch file . - 🇺🇸United States johnpicozzi Providence, RI
@Shreya_th Couldn't apply the patch via composer.
- Status changed to Needs work
8 months ago 2:55pm 10 November 2023 - 🇪🇸Spain ckrina Barcelona
Thanks for the work on this! While you are making the above changes, we recommend that you convert this patch to a merge request → . Merge requests are preferred over patches, plus we will,be able to test it with the Live Preview on the issue. Be sure to hide the old patch files as well. (Converting an issue to a merge request without other improvements is not recommended and will not receive credit.)
- 🇺🇸United States johnpicozzi Providence, RI
This issue may be resolved with the latest dev release. I will test again in the original environment and then close if that is the case.
- Assigned to johnpicozzi
- Issue was unassigned.
- 🇺🇸United States johnpicozzi Providence, RI
I'm still having this issue on my local. My above comment was based on a SimplyTest environment. The patch above doesn't apply cleanly and based on my review looks like it need some re-working. I'm not 100% sure the best way to apply an if statement to this code. I did create a fork to move this work into the GitLab workflow.
- Merge request !128Added If statement to resolve error message when logged out. → (Merged) created by johnpicozzi
- Status changed to Needs review
7 months ago 9:36pm 17 November 2023 - 🇺🇸United States johnpicozzi Providence, RI
Created a merge request to resolve this issue.
Also @ctrladel should get credit also because he helped with the code edits over my shoulder at NEDCamp.
- 🇺🇸United States ctrlADel North Carolina, USA
Confirming me and John worked on this at NEDCamp contrib day.
- Status changed to Fixed
7 months ago 5:23pm 18 November 2023 Automatically closed - issue fixed for 2 weeks with no activity.