Add permissions to view prev/next links

Created a new PR.
Added a new permission to view Prev/next links.

Note that it is disabled by default. I guess we can add an update hook to enable it for Anonymous & Authenticated users.

Hi @AstonVictor,
I'm ok with adding a new permission to access prev next links but it can't be a default behavior or nobody will get to see them leading people to think the module is not working properly.

I would rather make it configurable so that only if an "admin" chooses to enable that feature then the permission check will be executed.

Regards,
aronne

@aronne thats correct. I also think creating a new configurable permission, that can be assigned to a role by an administrative role user.

Updated my MR.
Added a new config on the settings page to enable/disable the access by permission.

Hi @MukhtarM,
I saw your MR and there are a lot of incorrect things. e.g. your permission is not on the permission page, some of the strings are now wrapped with the t() function, and other strings are using t() instead of $this->t(), there are code standard issues, the select field is not the best way for fields with multiple choices, etc.

hi @AstonVictor the translation string can be corrected, and i couldn't see any error if by default i am not selecting any permission or roles assigned to it (If that is meant by validation returns FALSE if the admin doesn't add configurations on the settings page.).

yea didn't added the new permission but thought to manage in the configuration form itself (Not sure about this).

But your way works too 👍. rather than these this workflow need to be confirmed to be correct by @aronne. Thanks

Note that we should update the MR because we merged the schema for the config. So, we should update the schema by including new configurations.

Updated the MR by updating schema config.

Hi @AstonVictor,
I merged your MR against 2.0.x
Please open a new MR for the 3.0.x branch as well so that we can close this issue.

Thank you and kind regards,
aronne.

Hi @aronne,

Actually, the 3.0.x version already has a permission check - https://git.drupalcode.org/project/prevnext/-/blob/3.0.x/prevnext.module...

and it has both global permission and entity type permission.

ok perfect thanks again @AstonVictor.

Automatically closed - issue fixed for 2 weeks with no activity.