Coding standard issues

Created on 1 November 2023, over 1 year ago
Updated 3 April 2024, 11 months ago

Problem/Motivation

FILE: /var/www/html/Live_Project/Patches/acquia_connector/src/Form/CredentialForm.php
----------------------------------------------------------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
----------------------------------------------------------------------------------------------
 127 | WARNING | \Drupal calls should be avoided in classes, use dependency injection instead
----------------------------------------------------------------------------------------------


FILE: /var/www/html/Live_Project/Patches/acquia_connector/src/Form/SettingsForm.php
----------------------------------------------------------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
----------------------------------------------------------------------------------------------
 154 | WARNING | \Drupal calls should be avoided in classes, use dependency injection instead
----------------------------------------------------------------------------------------------


FILE: /var/www/html/Live_Project/Patches/acquia_connector/src/Form/ConfigureApplicationForm.php
-----------------------------------------------------------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
-----------------------------------------------------------------------------------------------
 112 | WARNING | Unused variable $key.
-----------------------------------------------------------------------------------------------


FILE: /var/www/html/Live_Project/Patches/acquia_connector/src/Subscription.php
------------------------------------------------------------------------------------------------------------------------------------------
FOUND 0 ERRORS AND 6 WARNINGS AFFECTING 6 LINES
------------------------------------------------------------------------------------------------------------------------------------------
 322 | WARNING | t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead
 325 | WARNING | t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead
 328 | WARNING | t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead
 331 | WARNING | t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead
 334 | WARNING | t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead
 337 | WARNING | t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead
------------------------------------------------------------------------------------------------------------------------------------------


FILE: /var/www/html/Live_Project/Patches/acquia_connector/acquia_connector.module
-------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
FOUND 0 ERRORS AND 12 WARNINGS AFFECTING 6 LINES
-------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
 12 | WARNING | All constants defined by a module must be prefixed with the module's name, expected "ACQUIA_CONNECTOR_'ACQUIA_CONNECTOR_ACQUIA_SPI_DATA_VERSION'" but found
    |         | "'ACQUIA_CONNECTOR_ACQUIA_SPI_DATA_VERSION'"
 12 | WARNING | Global constants should not be used, move it to a class or interface
 17 | WARNING | All constants defined by a module must be prefixed with the module's name, expected "ACQUIA_CONNECTOR_'ACQUIA_CONNECTOR_ACQUIA_SPI_METHOD_CALLBACK'" but found
    |         | "'ACQUIA_CONNECTOR_ACQUIA_SPI_METHOD_CALLBACK'"
 17 | WARNING | Global constants should not be used, move it to a class or interface
 18 | WARNING | All constants defined by a module must be prefixed with the module's name, expected "ACQUIA_CONNECTOR_'ACQUIA_CONNECTOR_ACQUIA_SPI_METHOD_CRON'" but found
    |         | "'ACQUIA_CONNECTOR_ACQUIA_SPI_METHOD_CRON'"
 18 | WARNING | Global constants should not be used, move it to a class or interface
 19 | WARNING | All constants defined by a module must be prefixed with the module's name, expected "ACQUIA_CONNECTOR_'ACQUIA_CONNECTOR_ACQUIA_SPI_METHOD_DRUSH'" but found
    |         | "'ACQUIA_CONNECTOR_ACQUIA_SPI_METHOD_DRUSH'"
 19 | WARNING | Global constants should not be used, move it to a class or interface
 20 | WARNING | All constants defined by a module must be prefixed with the module's name, expected "ACQUIA_CONNECTOR_'ACQUIA_CONNECTOR_ACQUIA_SPI_METHOD_CREDS'" but found
    |         | "'ACQUIA_CONNECTOR_ACQUIA_SPI_METHOD_CREDS'"
 20 | WARNING | Global constants should not be used, move it to a class or interface
 21 | WARNING | All constants defined by a module must be prefixed with the module's name, expected "ACQUIA_CONNECTOR_'ACQUIA_CONNECTOR_ACQUIA_SPI_METHOD_INSIGHT'" but found
    |         | "'ACQUIA_CONNECTOR_ACQUIA_SPI_METHOD_INSIGHT'"
 21 | WARNING | Global constants should not be used, move it to a class or interface
-------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------


FILE: /var/www/html/Live_Project/Patches/acquia_connector/tests/src/Kernel/Form/ConfigureApplicationFormTest.php
----------------------------------------------------------------------------------------------------------------
FOUND 6 ERRORS AFFECTING 6 LINES
----------------------------------------------------------------------------------------------------------------
  20 | ERROR | [x] Missing function doc comment
  38 | ERROR | [x] Missing function doc comment
  58 | ERROR | [x] Missing function doc comment
  78 | ERROR | [x] Missing function doc comment
 110 | ERROR | [x] Missing function doc comment
 157 | ERROR | [x] Missing function doc comment
----------------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 6 MARKED SNIFF VIOLATIONS AUTOMATICALLY
----------------------------------------------------------------------------------------------------------------


FILE: /var/www/html/Live_Project/Patches/acquia_connector/tests/src/Kernel/AcquiaTelemetryIntegrationTest.php
-------------------------------------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
-------------------------------------------------------------------------------------------------------------
 11 | ERROR | Missing short description in doc comment
-------------------------------------------------------------------------------------------------------------


FILE: /var/www/html/Live_Project/Patches/acquia_connector/tests/src/Kernel/Migrate/d7/MigrateAcquiaConnectorConfigurationTest.php
---------------------------------------------------------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
---------------------------------------------------------------------------------------------------------------------------------
 19 | ERROR | Missing member variable doc comment
---------------------------------------------------------------------------------------------------------------------------------


FILE: /var/www/html/Live_Project/Patches/acquia_connector/tests/src/Kernel/ToolbarIntegrationTest.php
-----------------------------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
-----------------------------------------------------------------------------------------------------
 7 | ERROR | Missing short description in doc comment
-----------------------------------------------------------------------------------------------------


FILE: /var/www/html/Live_Project/Patches/acquia_connector/tests/src/Kernel/Controller/StatusControllerTest.php
---------------------------------------------------------------------------------------------------------------------------------------
FOUND 5 ERRORS AFFECTING 5 LINES
---------------------------------------------------------------------------------------------------------------------------------------
 124 | ERROR | The array declaration extends to column 87 (the limit is 80). The array content should be split up over multiple lines
 125 | ERROR | The array declaration extends to column 100 (the limit is 80). The array content should be split up over multiple lines
 126 | ERROR | The array declaration extends to column 100 (the limit is 80). The array content should be split up over multiple lines
 127 | ERROR | The array declaration extends to column 112 (the limit is 80). The array content should be split up over multiple lines
 128 | ERROR | The array declaration extends to column 92 (the limit is 80). The array content should be split up over multiple lines
---------------------------------------------------------------------------------------------------------------------------------------


FILE: /var/www/html/Live_Project/Patches/acquia_connector/tests/src/Kernel/Controller/AuthControllerTest.php
------------------------------------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
------------------------------------------------------------------------------------------------------------
 166 | ERROR | [x] Missing function doc comment
------------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
------------------------------------------------------------------------------------------------------------


FILE: /var/www/html/Live_Project/Patches/acquia_connector/tests/src/Kernel/SubscriptionRefreshTest.php
------------------------------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
------------------------------------------------------------------------------------------------------
 9 | ERROR | Missing short description in doc comment
------------------------------------------------------------------------------------------------------


FILE: /var/www/html/Live_Project/Patches/acquia_connector/tests/src/Kernel/HelpIntegrationTest.php
--------------------------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
--------------------------------------------------------------------------------------------------
 11 | ERROR | Missing short description in doc comment
--------------------------------------------------------------------------------------------------


FILE: /var/www/html/Live_Project/Patches/acquia_connector/tests/src/Unit/AcquiaTelemetryTest.php
------------------------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
------------------------------------------------------------------------------------------------
 15 | ERROR | Missing short description in doc comment
------------------------------------------------------------------------------------------------

Time: 496ms; Memory: 14MB

Steps to reproduce

Proposed resolution

Remaining tasks

User interface changes

API changes

Data model changes

🐛 Bug report
Status

Closed: outdated

Version

4.0

Component

Code

Created by

🇮🇳India adwivedi008

Live updates comments and jobs are added and updated live.
  • Coding standards

    It involves compliance with, or the content of coding standards. Requires broad community agreement.

Sign in to follow issues

Comments & Activities

Production build 0.71.5 2024