Check if null before counting array

Created on 1 November 2023, over 1 year ago

Updated 9 November 2023, over 1 year ago

Problem/Motivation

I ported file_resup → to D10+ and it has been working pretty good in production, but occasionally we get this error.

TypeError: count(): Argument #1 ($value) must be of type Countable|array, null given in count() (line 207 of core/modules/media_library/src/Form/FileUploadForm.php)

Proposed resolution

Can we add an empty check in that condition before counting please?

🐛 Bug report

Status

Closed: won't fix

Version

10.1 ✨

Component

Media →

Last updated 18 minutes ago

Maintained by
🇳🇱Netherlands @seanB
🇩🇪Germany @chr.fritsch
🇺🇸United States @phenaproxima
🇪🇸Spain @marcoscano

Created by

🇺🇸United States tim bozeman

Live updates comments and jobs are added and updated live.

Needs tests
The change is currently missing an automated test that fails when run with the original code, and succeeds when the bug has been fixed.

Comments & Activities

Issue created by @tim bozeman
Open in Jenkins → Open on Drupal.org →
Environment: PHP 5.3 & MySQL 5.5
last update over 1 year ago
Composer error. Unable to continue.
Open in Jenkins → Open on Drupal.org →
Environment: PHP 5.3 & MySQL 5.5
last update over 1 year ago
Composer error. Unable to continue.
Status changed to Needs work over 1 year ago12:22am 2 November 2023
Comment over 1 year ago →
🇺🇸United States smustgrave
Could we get a test to show this problem?
Status changed to Closed: won't fix over 1 year ago9:16pm 9 November 2023
Comment over 1 year ago →
🇺🇸United States tim bozeman
I have a feeling this was a symptom of something else, not a root cause.

contrib.social Blog FAQ Discussions

Production build 0.71.5 2024