- Issue created by @bohart
- last update
about 1 year ago 2 pass - @bohart opened merge request.
- Status changed to Needs review
about 1 year ago 4:37pm 31 October 2023 - 🇺🇦Ukraine bohart Lutsk, Ukraine
Merge request !13 is adding
.gitlab-ci.yml
configuration file to have two tests:
- latest D10 on PHP8.1;
- D9.5.x on PHP7.4.We have D8.9 tests at https://www.drupal.org/node/2827767/qa → , but it's (D8 testing) not supported anymore (D8 met his EOL back in 2021).
Here are the pipeline results: https://git.drupalcode.org/issue/site_settings-3398115/-/pipelines/42266
There will be more fixes in other tasks to have all stages green (I do not want to make this issue a huge one):1) For example, here is a link to PHPCS job (there are eight violations in 5 files to be fixed):
https://git.drupalcode.org/issue/site_settings-3398115/-/jobs/2565772) Also, 1 test (of 9 available) on the latest D10 failed (still works well on D9.5):
https://git.drupalcode.org/issue/site_settings-3398115/-/pipelines/42266... - 🇬🇧United Kingdom scott_euser
Thanks! Yep perfectly happy to drop the old tests. RTBC from my perspective when you and bobi-mel are happy with the phpcs/pipeline fixes. Probably many fixed in https://www.drupal.org/project/site_settings/issues/3395787 ✨ Provide new site settings loader that uses manage display, etc rather than flattening Needs work so I would guess that resolving them here may result in merge conflicts. You may want to consider it in a follow-up or we just focus on the new branch.
- 🇬🇧United Kingdom scott_euser
Just considering this; wonder if we should just stick to the default gitlab-ci template (which uses DA recommendations and keeps itself up to date). That way it does not end up like the current state where site settings is running ancient tests that are no longer relevant.
- Status changed to Fixed
about 1 year ago 7:04am 4 November 2023 - 🇬🇧United Kingdom scott_euser
I've added the Gitlab default template for now. Thanks!
Automatically closed - issue fixed for 2 weeks with no activity.