Provide new site settings loader that uses manage display, etc rather than flattening

Would welcome feedback on the proposed steps.

Am thinking this probably needs a 8.x-2.x branch in case anyone is extending/overriding services from this module, its probably unavoidable to cause breaks there. For those not extending/overriding services, should not be a problem to have a smooth upgrade path maintaining the status quo.

Progress is happening in the MR, crossing things off as I get through them.

scott_euser → credited bobi-mel → .

Adding credit to bobi-mel for type hints from https://www.drupal.org/project/site_settings/issues/3176342 ✨ Add type hint in function parameters and return values Fixed - thanks!

Nearly there with this. Need to resolve existing test failures, add new tests to cover new functionality, and update documentation. Then follow-up with this probably https://www.drupal.org/project/site_settings/issues/3398584 ✨ Remove _entity from site settings entity type IDs Postponed

Would appreciate feedback on approach and suggestions before we eventually lock in to this direction of travel.

Okay tests are all passing now, including new tests for twig extension for the full loader.

One warning from phpstan which is ignored in core; support request raised here for help ignoring that in contrib as well: https://www.drupal.org/project/drupal/issues/3399282 💬 Document how to use phpstan.neon in a contrib module Active

Just the documentation updates to be made otherwise this is ready now for 2.0.x branch.

Automatically closed - issue fixed for 2 weeks with no activity.