Remove _entity from site settings entity type IDs

Created on 2 November 2023, about 1 year ago
Updated 24 July 2024, 5 months ago

Problem/Motivation

Site settings architecture from the start is not following Drupal conventions. Update to remove _entity after https://www.drupal.org/project/site_settings/issues/3395787 Provide new site settings loader that uses manage display, etc rather than flattening Needs work and https://www.drupal.org/project/site_settings/issues/3365584 Add the ability to set a machine name for "settings_group" Needs review are merged

Should be 2.0.x branch, but not available in the 'version' list yet.

Feature request
Status

Postponed

Version

2.0

Component

Code

Created by

🇬🇧United Kingdom scott_euser

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Comments & Activities

  • Issue created by @scott_euser
  • Status changed to Postponed about 1 year ago
  • Status changed to Active about 1 year ago
  • First commit to issue fork.
  • Open in Jenkins → Open on Drupal.org →
    Core: 10.1.x + Environment: PHP 8.1 & MySQL 5.7
    last update about 1 year ago
    4 fail
  • @dharmeshbarot opened merge request.
  • Status changed to Needs review about 1 year ago
  • Status changed to Needs work about 1 year ago
  • 🇬🇧United Kingdom scott_euser

    Thanks for starting on this!

    I think the bigger challenge here is the update hook to use entity update manager to copy existing site settings entities and type entities to the new entities. Tests from gitlab pipelines needs looking at as well.

    Thanks!

  • Status changed to Postponed 5 months ago
  • 🇬🇧United Kingdom scott_euser

    Probably this is just going to be too much effort to actually make it happen. Going to leave it parked. Annoyingly I created this module back in 2016 when A) Drupal 8 was new and B) I did not really know what I was doing. This may just remain a hangover of that unfortunately.

Production build 0.71.5 2024