Fix issue with changing between responsive views and Gin Toolbar over menus

Created on 31 October 2023, 8 months ago
Updated 16 December 2023, 7 months ago

Problem/Motivation

Cannot change the responsive views easily.

Steps to reproduce

Open a page and click on a different responsive view
Try to change to another responsive view.
When I try to select a second responsive view, all of the other options are hidden and I cannot select a different view.

Proposed resolution

  • Use a z-index of 500 for the responsive preview main container, to let the Gin Toolbar over
  • Add color and background color for the active responsive preview using Gin's variables ( --gin-color-button-text and --gin-color-primary to match with the hover status.
  • Fix the size of the responsive preview icon active and the color to match with Gin's variables ( ---gin-icon-color )
  • ? UX/UI designer responsibilities
    I only have access to the Drupal Admin UI - Claro design system
    But, No access for the Gin Admin theme design system.
    Only thinking of what we can see out of the box in the Gin Admin theme

    Would you like to have the look of active responsive view same as the hover ?
    Would you like to have the icon as is ? ( which looks like the default icon from responsive view )
    background-color: var(--gin-icon-color); - with the mask for the icon

    Or have the icon with background-color: var(--gin-color-button-text); - with the mask too

Remaining tasks

  • ✅ File an issue
  • ✅ Addition/Change/Update/Fix to this project
  • ✅ Testing to ensure no regression
  • ✅ Automated unit/functional testing coverage
  • ➖ Developer Documentation
  • ➖ User Guide Documentation
  • ? UX/UI designer responsibilities
  • ✅ Accessibility and Readability
  • ❌ Code review from 1 team member
  • ❌ Full testing and approval
  • ❌ Credit contributors
  • ❌ Review with the product owner
  • ❌ Update Release Notes
  • ❌ Release

User interface changes

After the Fix:

Or

API changes

  • N/A

Data model changes

  • N/A
🐛 Bug report
Status

Needs review

Version

3.0

Component

Code

Created by

🇯🇴Jordan Rajab Natshah Jordan

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Comments & Activities

Production build 0.69.0 2024