Fix issue reported by GitLab Ci.

Created on 31 October 2023, over 1 year ago
Updated 17 January 2024, about 1 year ago
📌 Task
Status

Needs review

Version

1.0

Component

Code

Created by

🇮🇳India rajeshreeputra Pune

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Comments & Activities

  • Issue created by @rajeshreeputra
  • 🇮🇳India rajeshreeputra Pune


    phpstan
    phpunit-d9
    phpunit-d10

  • First commit to issue fork.
  • 🇮🇳India viren18febs

    I have fixed the issue reported by PhpStan. please review

  • 🇮🇳India pray_12

    Hi,
    After applying the patch #5, the patch is successfully applied, but there are still some errors found when running the phpcs command.

    FILE:/acquia_cms_search/tests/src/Kernel/AcquiaFacetFacadeTest.php
    ------------------------------------------------------------------------------------------------------------------------
    FOUND 1 ERROR AFFECTING 1 LINE
    ------------------------------------------------------------------------------------------------------------------------
    36 | ERROR | Missing short description in doc comment
    ------------------------------------------------------------------------------------------------------------------------

    FILE: /acquia_cms_search/README.md
    ---------------------------------------------------------------------------------------
    FOUND 0 ERRORS AND 2 WARNINGS AFFECTING 2 LINES
    ---------------------------------------------------------------------------------------
    21 | WARNING | Line exceeds 80 characters; contains 177 characters
    23 | WARNING | Line exceeds 80 characters; contains 233 characters
    ---------------------------------------------------------------------------------------

  • Status changed to Needs review about 1 year ago
  • 🇮🇳India viren18febs

    HI @pray_12
    As per the issues summary I have fixed the phpstan issues only, so you can check with phpstan.

Production build 0.71.5 2024