- Issue created by @Bobik
- Assigned to Sahana _N
- @sahana-_n opened merge request.
- Issue was unassigned.
- Status changed to Needs review
8 months ago 3:40pm 7 November 2023 - Status changed to Needs work
8 months ago 9:24pm 7 November 2023 - 🇺🇦Ukraine Bobik
Hi @Sahana _N
Thanks for your contribution. The block works well.
But please fix the coding standards and could you explain to me why you use the additional array for each of the options? - 🇺🇦Ukraine Bobik
Hi @Sahana _N
I have reviewed and tested your solution. However, it is very easy to break the block if you enter an unnecessary character. I think it would be better to add a separate configuration form for customization and add the Configure button in the modules list page like as on the screenshot - Assigned to Sahana _N
- 🇮🇳India Sahana _N
Hi @bobi-mel
Thanks for the review. Sure I will add a separate configuration form for customization.
In the form for each option do I need to add a separate input field?
Thank you!!
- 🇺🇦Ukraine Bobik
Hi @Sahana _N
Yes, sure for each option need to add a separate input field. - Issue was unassigned.
- Status changed to Needs review
8 months ago 2:49pm 9 November 2023 -
bobi-mel →
committed 5f6b6f77 on 1.0.x authored by
Sahana _N →
Issue #3397545 by bobi-mel: Add the ability to configure the Darkmode...
-
bobi-mel →
committed 5f6b6f77 on 1.0.x authored by
Sahana _N →
- Status changed to Fixed
8 months ago 6:00pm 9 November 2023 - 🇺🇦Ukraine Bobik
I refactored and updated your MR. Thanks for your contribution.
Automatically closed - issue fixed for 2 weeks with no activity.