- Issue created by @catch
- @nbeaucage opened merge request.
- Status changed to Needs review
8 months ago 3:29pm 31 October 2023 - π¨π¦Canada nbeaucage Montreal
I had to be specific with the versions for the
@deprecated
statement, so I looked for the last/only usage removal ofCacheDecoratorInterface
in 2020, which seemed to be pointing to the9.0.0
version of Drupal core.I found this commit: Issue #3092090 by Berdir, Wim Leers, plach, amateescu: Remove legacy Path Alias subsystem, and then this issue: Remove legacy Path Alias subsystem β , which was Closed (fixed) for the 9.0.x-dev version of Drupal core.
Please feel free to have me update the
@deprecated
statement as needed if it seems incorrect. - Status changed to Needs work
8 months ago 6:59pm 31 October 2023 - πΊπΈUnited States smustgrave
So depends when this gets committed. But 9.0 has passed.
Could be deprecated in 10.2 and removed in D11.
But will need it's own change record and the link in the comment should point to that CR. Example https://www.drupal.org/node/3387830 β
- Assigned to nbeaucage
- Status changed to Needs review
8 months ago 8:46pm 31 October 2023 - π¨π¦Canada nbeaucage Montreal
- Created draft Change record: \Drupal\Core\CacheDecorator\CacheDecoratorInterface is deprecated β
- Adjusted deprecation statement to
@deprecated in drupal:10.2.0 and is removed from drupal:11.0.0.
- Status changed to RTBC
8 months ago 4:29pm 2 November 2023 - Issue was unassigned.
- π¨π¦Canada nbeaucage Montreal
@smustgrave Thank you for the feedback!
I have one question regarding the Change record being in a draft state: when should it be published (by me or anyone else)? Once this issue's MR is merged? I'm new to the Change record process, so I'm wondering what to do about that.
Thanks for your time!
- πΊπΈUnited States smustgrave
When the committer merges the code they will publish the CR for ya. So essentially for this one would just keep an eye out if any additional feedback comes through or is sent back for whatever reason.
- π§πͺBelgium kristiaanvandeneynde Antwerp, Belgium
Change record looks good, reasoning is also sound. +1
- First commit to issue fork.
- π¬π§United Kingdom longwave UK
Changed the wording to the common wording we use when there is no replacement; the deprecation message tells you what to do (in this case, you are on your own) and the change record tells you why.
- π¬π§United Kingdom longwave UK
Committed and pushed 4cff7cd61d to 11.x and c31491b7c3 to 10.2.x. Thanks!
-
longwave β
committed c31491b7 on 10.2.x
Issue #3397488 by nbeaucage, longwave, smustgrave, catch: Deprecate...
-
longwave β
committed c31491b7 on 10.2.x
- Status changed to Fixed
8 months ago 9:11pm 7 November 2023 -
longwave β
committed 4cff7cd6 on 11.x
Issue #3397488 by nbeaucage, longwave, smustgrave, catch: Deprecate...
-
longwave β
committed 4cff7cd6 on 11.x
Automatically closed - issue fixed for 2 weeks with no activity.