Issues reported by PHPStan

$ php vendor/bin/phpstan analyze $_WEB_ROOT/modules/custom/$CI_PROJECT_NAME $PHPSTAN_CONFIGURATION --no-progress || EXIT_CODE=$? ------ ------------------------------------------------------------------------------ Line src/Controller/Report/DaysOfMonth.php ------ ------------------------------------------------------------------------------ 48 Unsafe usage of new static(). 💡 See: https://phpstan.org/blog/solving-phpstan-error-unsafe-usage-of-new-static ------ ------------------------------------------------------------------------------ ------ ------------------------------------------------------------------------------ Line src/Controller/Report/DaysOfWeek.php ------ ------------------------------------------------------------------------------ 48 Unsafe usage of new static(). 💡 See: https://phpstan.org/blog/solving-phpstan-error-unsafe-usage-of-new-static ------ ------------------------------------------------------------------------------ ------ ------------------------------------------------------------------------------ Line src/Controller/Report/HitDetails.php ------ ------------------------------------------------------------------------------ 32 Unsafe usage of new static(). 💡 See: https://phpstan.org/blog/solving-phpstan-error-unsafe-usage-of-new-static ------ ------------------------------------------------------------------------------ ------ ------------------------------------------------------------------------------ Line src/Controller/Report/HostController.php ------ ------------------------------------------------------------------------------ 32 Unsafe usage of new static(). 💡 See: https://phpstan.org/blog/solving-phpstan-error-unsafe-usage-of-new-static ------ ------------------------------------------------------------------------------ ------ ------------------------------------------------------------------------------ Line src/Controller/Report/Hours.php ------ ------------------------------------------------------------------------------ 48 Unsafe usage of new static(). 💡 See: https://phpstan.org/blog/solving-phpstan-error-unsafe-usage-of-new-static ------ ------------------------------------------------------------------------------ ------ ------------------------------------------------------------------------------ Line src/Controller/Report/MonthlyHistory.php ------ ------------------------------------------------------------------------------ 48 Unsafe usage of new static(). 💡 See: https://phpstan.org/blog/solving-phpstan-error-unsafe-usage-of-new-static ------ ------------------------------------------------------------------------------ ------ ------------------------------------------------------------------------------ Line src/Controller/Report/Node.php ------ ------------------------------------------------------------------------------ 51 Unsafe usage of new static(). 💡 See: https://phpstan.org/blog/solving-phpstan-error-unsafe-usage-of-new-static ------ ------------------------------------------------------------------------------ ------ ------------------------------------------------------------------------------ Line src/Controller/Report/RecentHits.php ------ ------------------------------------------------------------------------------ 32 Unsafe usage of new static(). 💡 See: https://phpstan.org/blog/solving-phpstan-error-unsafe-usage-of-new-static ------ ------------------------------------------------------------------------------ ------ ------------------------------------------------------------------------------ Line src/Controller/Report/Referer.php ------ ------------------------------------------------------------------------------ 41 Unsafe usage of new static(). 💡 See: https://phpstan.org/blog/solving-phpstan-error-unsafe-usage-of-new-static ------ ------------------------------------------------------------------------------ ------ ------------------------------------------------------------------------------ Line src/Controller/Report/RouteController.php ------ ------------------------------------------------------------------------------ 32 Unsafe usage of new static(). 💡 See: https://phpstan.org/blog/solving-phpstan-error-unsafe-usage-of-new-static ------ ------------------------------------------------------------------------------ ------ ------------------------------------------------------------------------------ Line src/Controller/Report/TopPageController.php ------ ------------------------------------------------------------------------------ 33 Unsafe usage of new static(). 💡 See: https://phpstan.org/blog/solving-phpstan-error-unsafe-usage-of-new-static ------ ------------------------------------------------------------------------------ ------ ------------------------------------------------------------------------------ Line src/Controller/Report/UserActivity.php ------ ------------------------------------------------------------------------------ 43 Unsafe usage of new static(). 💡 See: https://phpstan.org/blog/solving-phpstan-error-unsafe-usage-of-new-static ------ ------------------------------------------------------------------------------ ------ ------------------------------------------------------------------------------ Line src/Controller/Visitors.php ------ ------------------------------------------------------------------------------ 35 Unsafe usage of new static(). 💡 See: https://phpstan.org/blog/solving-phpstan-error-unsafe-usage-of-new-static ------ ------------------------------------------------------------------------------ ------ ------------------------------------------------------------------------------ Line src/Form/RebuildDeviceForm.php ------ ------------------------------------------------------------------------------ 37 Unsafe usage of new static(). 💡 See: https://phpstan.org/blog/solving-phpstan-error-unsafe-usage-of-new-static ------ ------------------------------------------------------------------------------ ------ ------------------------------------------------------------------------------ Line src/Form/RebuildIpAddressForm.php ------ ------------------------------------------------------------------------------ 36 Unsafe usage of new static(). 💡 See: https://phpstan.org/blog/solving-phpstan-error-unsafe-usage-of-new-static ------ ------------------------------------------------------------------------------ ------ ------------------------------------------------------------------------------ Line src/Form/RebuildRouteForm.php ------ ------------------------------------------------------------------------------ 37 Unsafe usage of new static(). 💡 See: https://phpstan.org/blog/solving-phpstan-error-unsafe-usage-of-new-static ------ ------------------------------------------------------------------------------ ------ ------------------------------------------------------------------------------ Line src/Plugin/Block/VisitorsBlock.php ------ ------------------------------------------------------------------------------ 116 Unsafe usage of new static(). 💡 See: https://phpstan.org/blog/solving-phpstan-error-unsafe-usage-of-new-static ------ ------------------------------------------------------------------------------ ------ ------------------------------------------------------------------------------ Line src/Plugin/Block/VisitorsPopularBlock.php ------ ------------------------------------------------------------------------------ 84 Unsafe usage of new static(). 💡 See: https://phpstan.org/blog/solving-phpstan-error-unsafe-usage-of-new-static ------ ------------------------------------------------------------------------------ ------ ---------------------------------------------------------------------- Line src/Plugin/views/area/VisitorsDisplayLink.php ------ ---------------------------------------------------------------------- 84 \Drupal calls should be avoided in classes, use dependency injection instead ------ ---------------------------------------------------------------------- ------ ---------------------------------------------------------------------- Line src/Plugin/views/field/VisitorsBrowserVersion.php ------ ---------------------------------------------------------------------- 24 \Drupal calls should be avoided in classes, use dependency injection instead ------ ---------------------------------------------------------------------- ------ ----------------------------------------------------------- ------ ------------------------------------------------------------------------------ Line visitors_geoip/src/Controller/Cities.php ------ ------------------------------------------------------------------------------ 41 Unsafe usage of new static(). 💡 See: https://phpstan.org/blog/solving-phpstan-error-unsafe-usage-of-new-static ------ ------------------------------------------------------------------------------ ------ ------------------------------------------------------------------------------ Line visitors_geoip/src/Controller/CityHits.php ------ ------------------------------------------------------------------------------ 41 Unsafe usage of new static(). 💡 See: https://phpstan.org/blog/solving-phpstan-error-unsafe-usage-of-new-static ------ ------------------------------------------------------------------------------ ------ ------------------------------------------------------------------------------ Line visitors_geoip/src/Controller/Countries.php ------ ------------------------------------------------------------------------------ 41 Unsafe usage of new static(). 💡 See: https://phpstan.org/blog/solving-phpstan-error-unsafe-usage-of-new-static ------ ------------------------------------------------------------------------------ ------ ------------------------------------------------------------------------------ Line visitors_geoip/src/Form/RebuildLocationForm.php ------ ------------------------------------------------------------------------------ 37 Unsafe usage of new static(). 💡 See: https://phpstan.org/blog/solving-phpstan-error-unsafe-usage-of-new-static ------ ------------------------------------------------------------------------------ ------ ------------------------------------------------------------------------------ Line visitors_geoip/src/Form/SettingsForm.php ------ ------------------------------------------------------------------------------ 27 Unsafe usage of new static(). 💡 See: https://phpstan.org/blog/solving-phpstan-error-unsafe-usage-of-new-static ------ ------------------------------------------------------------------------------ ------ --------------------------------------------------------- Line visitors_geoip/tests/src/Unit/Form/SettingsFormTest.php ------ --------------------------------------------------------- 64 Call to deprecated method withConsecutive() of class PHPUnit\Framework\MockObject\Builder\InvocationMocker. ------ ---------------------------------------------------------

Comments & Activities

Issue created by @bluegeek9
Issue was unassigned.
Comment 8 months ago →
🇺🇸United States bluegeek9
First commit to issue fork.
First commit to issue fork.
Merge request !107PHPStan error fixes → (Merged) created by SandeepSingh199
Comment 7 months ago →
System Message

bluegeek9 → committed 5ef130d4 on 8.x-2.x authored by SandeepSingh199 →
Issue #3397326: Issues reported by PHPStan
Merge request !108Issue #3397326 by bluegeek9, SandeepSingh199: Issues reported by PHPStan → (Merged) created by bluegeek9

Comment 7 months ago →

System Message

bluegeek9 → committed 4314f6b0 on 8.x-2.x

Issue #3397326 by bluegeek9, SandeepSingh199: Issues reported by PHPStan

Status changed to Fixed 7 months ago7:37pm 13 December 2023
Comment 7 months ago →
🇺🇸United States bluegeek9
Comment 6 months ago →
System Message
Automatically closed - issue fixed for 2 weeks with no activity.
Status changed to Fixed about 1 month ago3:41pm 22 May 2024
Comment about 1 month ago →
🇺🇸United States bluegeek9
This issue was resolved. A new release, 8.x-2.17, will be made soon, May 31st.

This is an excellent opportunity to beta test the dev branch, and report any issues.

Contributors (5)

bluegeek9 → , roshni27 → , abhishek_gupta1 → , sarwan_verma → , SandeepSingh199 →

Changelog

Issues: 32 issues resolved.

Changes since 8.x-2.16 → :

Bug

#3432630 → : Remove Not rendering HTML

#3395217 → by bluegeek9 → : On a fresh install of a Drupal site with this module included, we get dependency errors

#3400985 → by bluegeek9 → : Site break when placed visitors module

#3413155 → by abhishek_gupta1 → , bluegeek9 → : Give Default value to all $agent keys

#3383142 → by bluegeek9 → : ParseError: syntax error, unexpected

#3380760 → : Warning: Undefined array key

Feature

#3376256 → : Page Performance Metrics

#3378568 → : Ajax Replace Report

#3376234 → : Route reports

#3378580 → : Browser Report(s)

#1087268 → by bluegeek9 → : Exclude robots from the statistics

#3376233 → by bluegeek9 → : View filter date range

#3369318 → : Log OS and device infomation - BrowserCap replacement

#3376235 → by bluegeek9 → : Drush command: Download MaxMind database

#3250285 → by bluegeek9 → : Performance: Add db indexes

Task

#3389685 → : Three different errors displayed

#3376397 → by bluegeek9 → , roshni27 → : Remove block settings from visitors.config

#3376392 → : Move Visitors Report menu

#3444385 → : Module path

#3443031 → by bluegeek9 → : Issues reported by PHPCS

#3392006 → by bluegeek9 → , sarwan_verma → : watchdog_exception() deprecated

#3423013 → : Deprecated function user_role_names()

#3423001 → by bluegeek9 → : composer.json missing "repositories"

#3397326 → by bluegeek9 → , SandeepSingh199 → : Issues reported by PHPStan

#3401384 → : Remove Drupal 9 from GitLab CI

#3393046 → by bluegeek9 → : Code Coverage

#3377961 → : Replace visitors/hosts reports with views

#3377962 → : Replace visitors/hits with Views

#3377964 → : Replace /visitors/pages with Views

#3377960 → by bluegeek9 → : Log visitor local time

#3376241 → : Drush Command: Rebuild Geo Location

#3377958 → : Tracking cookies

Issues reported by PHPStan

Problem/Motivation

Steps to reproduce

Proposed resolution

Remaining tasks

User interface changes

API changes

Data model changes

Merge Requests

!108Issues reported by PHPStan
Merged

!107Issues reported by PHPStan
Merged

Comments & Activities

Contributors (5)

Changelog

Bug

Feature

Task

Issues reported by PHPStan

Problem/Motivation

Steps to reproduce

Proposed resolution

Remaining tasks

User interface changes

API changes

Data model changes

Merge Requests

!108Issues reported by PHPStanMerged

!107Issues reported by PHPStanMerged

Comments & Activities

Contributors (5)

Changelog

Bug

Feature

Task

!108Issues reported by PHPStan
Merged

!107Issues reported by PHPStan
Merged